linux-kernel - Re: [PATCH v2] qlcnic: fix a memory leak in qlcnic_sriov_set_guest_vlan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ec568a7-709a-4251-9f0d-7e57c12ce809@redhat.com>
Date: Thu, 6 Mar 2025 11:34:02 +0100
From: Paolo Abeni <pabeni@...hat.com>
To: Haoxiang Li <haoxiang_li2024@....com>, shshaikh@...vell.com,
 manishc@...vell.com, GR-Linux-NIC-Dev@...vell.com, andrew+netdev@...n.ch,
 davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
 rajesh.borundia@...gic.com, sucheta.chakraborty@...gic.com
Cc: netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
 stable@...r.kernel.org
Subject: Re: [PATCH v2] qlcnic: fix a memory leak in
 qlcnic_sriov_set_guest_vlan_mode()

On 3/6/25 11:32 AM, Paolo Abeni wrote:
> On 3/5/25 11:09 AM, Haoxiang Li wrote:
>> Add qlcnic_sriov_free_vlans() to free the memory allocated by
>> qlcnic_sriov_alloc_vlans() if qlcnic_sriov_alloc_vlans() fails
>> or "sriov->allowed_vlans" fails to be allocated.
>>
>> Fixes: 91b7282b613d ("qlcnic: Support VLAN id config.")
>> Cc: stable@...r.kernel.org
>> Signed-off-by: Haoxiang Li <haoxiang_li2024@....com>

Whoops, I forgot: please include the target tree name ('net' in this
case) in the subj prefix - in the next iteration should be 'PATCH net v3'.

Thanks,

Paolo