linux-kernel - Re: [PATCH v2 2/2] wifi: mwifiex: Fix HT40 bandwidth issue.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250306103754.GB19853@francesco-nb>
Date: Thu, 6 Mar 2025 11:37:54 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: Jeff Chen <jeff.chen_1@....com>
Cc: linux-wireless@...r.kernel.org, linux-kernel@...r.kernel.org,
	briannorris@...omium.org, kvalo@...nel.org, francesco@...cini.it,
	tsung-hsien.hsieh@....com, s.hauer@...gutronix.de
Subject: Re: [PATCH v2 2/2] wifi: mwifiex: Fix HT40 bandwidth issue.

Hello Jeff,

On Wed, Feb 05, 2025 at 09:28:43AM +0800, Jeff Chen wrote:
> This patch addresses an issue where, despite the AP supporting 40MHz
> bandwidth, the connection was limited to 20MHz. Without this fix,
> even if the access point supports 40MHz, the bandwidth after
> connection remains at 20MHz. This issue is not a regression.

As you know this patch came after us (Toradex) reported some issue
connecting to 2.4GHz network using IW416.

However according to this commit message this actual fix is not related
to the issue in which it was not possible to connect at all, but it's
just an improvement. Can you confirm this?

Can you please also answer the last comment I had in the previous version of
this patch, see https://lore.kernel.org/all/Z44vj59nWIiswq7s@gaggiata.pivistrello.it/
?

Reported here again for you convenience:

  setting `radio_type |= (CHAN_BW_40MHZ << 2)` seems the only real change on this
  patch, correct? Anything else is cosmetic, correct?

  would doing just this change be equivalent, right?

  	SET_SECONDARYCHAN(chan_list->chan_scan_param[0].
  			  radio_type | (CHAN_BW_40MHZ << 2),
  			  (bss_desc->bcn_ht_oper->ht_param &
  			  IEEE80211_HT_PARAM_CHA_SEC_OFFSET));

Thanks,
Francesco