linux-kernel - Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1573D5D6-AFED-4D92-8112-B0C6BB52D5FF@gmail.com>
Date: Thu, 6 Mar 2025 12:47:31 +0100
From: Piotr Oniszczuk <piotr.oniszczuk@...il.com>
To: Andy Yan <andyshrk@....com>
Cc: heiko@...ech.de,
 neil.armstrong@...aro.org,
 sebastian.reichel@...labora.com,
 devicetree@...r.kernel.org,
 hjc@...k-chips.com,
 mripard@...nel.org,
 linux-kernel@...r.kernel.org,
 linux-rockchip@...ts.infradead.org,
 yubing.zhang@...k-chips.com,
 dri-devel@...ts.freedesktop.org,
 Andy Yan <andy.yan@...k-chips.com>,
 krzk+dt@...nel.org,
 robh@...nel.org,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 0/6] Add support for RK3588 DisplayPort Controller


> Wiadomość napisana przez Andy Yan <andyshrk@....com> w dniu 6 mar 2025, o godz. 09:53:
> 
> 
> Hi,
> 
> 在 2025-03-06 16:42:00，"Piotr Oniszczuk" <piotr.oniszczuk@...il.com> 写道：
>> 
>> 
>>> Wiadomość napisana przez Andy Yan <andyshrk@....com> w dniu 6 mar 2025, o godz. 01:59:
>>> 
>>> 
>>> 
>>> 
>>> Both of the two config options should be enabled.
>>> andy@...480:~/WorkSpace/linux-next$ rg DW_DP .config
>>> 4044:CONFIG_ROCKCHIP_DW_DP=y
>> 
>> here i’m a bit lost….
>> greping on full kernel sources (with applied https://patchwork.kernel.org/project/linux-rockchip/list/?series=936784) gives me no single appearance of ROCKCHIP_DW_DP…
>> Do i miss something?
> 
> see PATCH 3/6:   
> 
> 
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index 26c4410b2407..c8638baf9641 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -8,6 +8,7 @@ config DRM_ROCKCHIP
> select DRM_PANEL
> select VIDEOMODE_HELPERS
> select DRM_ANALOGIX_DP if ROCKCHIP_ANALOGIX_DP
> + select DRM_DW_DP if ROCKCHIP_DW_DP
> select DRM_DW_HDMI if ROCKCHIP_DW_HDMI
> select DRM_DW_HDMI_QP if ROCKCHIP_DW_HDMI_QP
> select DRM_DW_MIPI_DSI if ROCKCHIP_DW_MIPI_DSI
> @@ -58,6 +59,12 @@ config ROCKCHIP_CDN_DP
>  RK3399 based SoC, you should select this
>  option.
> 
> +config ROCKCHIP_DW_DP
> + bool "Rockchip specific extensions for Synopsys DW DP"
> + help
> +  Choose this option for Synopsys DesignWare Cores DisplayPort
> +  transmit controller support on Rockchip SoC.
> 
> https://lore.kernel.org/linux-rockchip/047EECFC-7E55-44EC-896F-13FE04333E4D@gmail.com/T/#m178a325ea0ebc64187aae474d77c3f7a9e0bc93d
>> 


Ah my bad!
One patch patch was commented - so not all dp code was applied.

Now it is much better:

root@...h-frontend-56b0f018b5e0:~ # dmesg | grep drm
[    9.795380] panthor fb000000.gpu: [drm] clock rate = 198000000
[    9.796257] panthor fb000000.gpu: [drm] mali-g610 id 0xa867 major 0x0 minor 0x0 status 0x5
[    9.796262] panthor fb000000.gpu: [drm] Features: L2:0x7120306 Tiler:0x809 Mem:0x301 MMU:0x2830 AS:0xff
[    9.796265] panthor fb000000.gpu: [drm] shader_present=0x50005 l2_present=0x1 tiler_present=0x1
[    9.851869] panthor fb000000.gpu: [drm] Firmware protected mode entry not be supported, ignoring
[    9.851921] panthor fb000000.gpu: [drm] Firmware git sha: 814b47b551159067b67a37c4e9adda458ad9d852
[    9.852127] panthor fb000000.gpu: [drm] CSF FW using interface v1.1.0, Features 0x0 Instrumentation features 0x71
[    9.852436] [drm] Initialized panthor 1.3.0 for fb000000.gpu on minor 0
[   10.003108] rockchip-drm display-subsystem: bound fdd90000.vop (ops vop2_component_ops)
[   10.004705] rockchip-drm display-subsystem: bound fde60000.dp (ops dw_dp_rockchip_component_ops)
[   10.006085] rockchip-drm display-subsystem: bound fdea0000.hdmi (ops dw_hdmi_qp_rockchip_ops)
[   10.006679] [drm] Initialized rockchip 1.0.0 for display-subsystem on minor 1
[   10.006737] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes
[   10.007663] rockchip-drm display-subsystem: [drm] Cannot find any crtc or sizes

Unfortunately still nothing on screen

dri state: https://gist.github.com/warpme/5e971dfd2e9fd52fae76641831cebe46

and kernel dmesg https://termbin.com/r0m3

i’m not sure what is missing (some dts enablement or….)