linux-kernel - Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description for ipq9574

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <33bb1cb2-0c5e-402b-a5c6-9604b1dd8d99@kernel.org>
Date: Thu, 6 Mar 2025 13:06:13 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Varadarajan Narayanan <quic_varada@...cinc.com>, bhelgaas@...gle.com,
 lpieralisi@...nel.org, kw@...ux.com, manivannan.sadhasivam@...aro.org,
 robh@...nel.org, krzk+dt@...nel.org, conor+dt@...nel.org, vkoul@...nel.org,
 kishon@...nel.org, andersson@...nel.org, konradybcio@...nel.org,
 p.zabel@...gutronix.de, quic_nsekar@...cinc.com,
 dmitry.baryshkov@...aro.org, linux-arm-msm@...r.kernel.org,
 linux-pci@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-phy@...ts.infradead.org
Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Subject: Re: [PATCH v11 3/7] dt-bindings: PCI: qcom: Use sdx55 reg description
 for ipq9574

On 06/03/2025 12:52, Krzysztof Kozlowski wrote:
> On 20/02/2025 10:42, Varadarajan Narayanan wrote:
>> All DT entries except "reg" is similar between ipq5332 and ipq9574. ipq9574
>> has 5 registers while ipq5332 has 6. MHI is the additional (i.e. sixth
>> entry). Since this matches with the sdx55's "reg" definition which allows
>> for 5 or 6 registers, combine ipq9574 with sdx55.
>>
>> This change is to prepare ipq9574 to be used as ipq5332's fallback
>> compatible.
>>
>> Acked-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
>> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> Unreviewed.
> 
>> Signed-off-by: Varadarajan Narayanan <quic_varada@...cinc.com>
>> ---
>> v8: Add 'Reviewed-by: Krzysztof Kozlowski'
>> ---
>>  Documentation/devicetree/bindings/pci/qcom,pcie.yaml | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> index 7235d6554cfb..4b4927178abc 100644
>> --- a/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> +++ b/Documentation/devicetree/bindings/pci/qcom,pcie.yaml
>> @@ -169,7 +169,6 @@ allOf:
>>              enum:
>>                - qcom,pcie-ipq6018
>>                - qcom,pcie-ipq8074-gen3
>> -              - qcom,pcie-ipq9574
> 
> Why you did not explain that you are going to affect users of DTS?
> 
> NAK

I did not connect the dots, but I pointed out that you break users and
your DTS is wrong:
https://lore.kernel.org/all/f7551daa-cce5-47b3-873f-21b9c5026ed2@kernel.org/

so you should come back with questions to clarify what to do, not keep
pushing this incorrect patchset.

My bad, I should really have zero trust.

Best regards,
Krzysztof