linux-kernel - Re: [PATCH] RDMA/erdma: Prevent use-after-free in erdma_accept

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <edd17fe8-5a27-4ae3-cec6-b2ecd01b1b76@linux.alibaba.com>
Date: Thu, 6 Mar 2025 20:06:40 +0800
From: Cheng Xu <chengyou@...ux.alibaba.com>
To: Leon Romanovsky <leon@...nel.org>, Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org, linux-rdma@...r.kernel.org,
 Jason Gunthorpe <jgg@...pe.ca>, Kai Shen <kaishen@...ux.alibaba.com>,
 Yang Li <yang.lee@...ux.alibaba.com>, cocci@...ia.fr,
 LKML <linux-kernel@...r.kernel.org>,
 Christophe Leroy <christophe.leroy@...roup.eu>
Subject: Re: [PATCH] RDMA/erdma: Prevent use-after-free in
 erdma_accept_newconn()



On 3/6/25 4:47 PM, Leon Romanovsky wrote:
> On Wed, Mar 05, 2025 at 03:20:41PM +0100, Markus Elfring wrote:
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Wed, 5 Mar 2025 15:07:51 +0100
>>
>> The implementation of the function “erdma_accept_newconn” contained
>> still the statement “new_cep->sock = NULL” after
>> the function call “erdma_cep_put(new_cep)”.
>> Thus delete an inappropriate reset action.
>>
>> Reported-by: Cheng Xu <chengyou@...ux.alibaba.com>
> 
> Cheng, please resubmit this patch, I'm experiencing the same issues as
> Christophe has here https://lore.kernel.org/all/20a1a47c-8906-44e8-92e6-9b3e698b1491@web.de
> and it looks like Markus continues do not listen to the feedback.
> 

Hi Leon,

Sure, I just resubmitted the patch, please review and apply.

Thanks,
Cheng Xu

> Thanks