[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <4264609.3VsfAaAtOV@nerdopolis2>
Date: Wed, 05 Mar 2025 20:30:11 -0500
From: Adam Simonelli <adamsimonelli@...il.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: linux-serial@...r.kernel.org, linux-kernel@...r.kernel.org,
Jiri Slaby <jirislaby@...nel.org>,
Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
Steven Rostedt <rostedt@...dmis.org>,
John Ogness <john.ogness@...utronix.de>,
Sergey Senozhatsky <senozhatsky@...omium.org>, Petr Mladek <pmladek@...e.com>
Subject:
Re: [PATCH v7 2/3] ttynull: Add an option to allow ttynull to be used as a
console device
On Wednesday, March 5, 2025 2:18:39 PM EST Andy Shevchenko wrote:
> On Wed, Mar 5, 2025 at 6:30 AM <adamsimonelli@...il.com> wrote:
> >
> > From: Adam Simonelli <adamsimonelli@...il.com>
> >
> > The new config option, CONFIG_NULL_TTY_DEFAULT_ CONSOLE will allow
> > ttynull to be initialized by console_initcall() and selected as a
> > possible console device.
>
> ...
>
> > In order to use this driver, you should redirect the console to this
> > - TTY, or boot the kernel with console=ttynull.
> > + TTY, boot the kernel with console=ttynull, or enable
> > + CONFIG_NULL_TTY_DEFAULT_CONSOLE.
>
> I haven't checked what it looks like in menuconfig / nconfig / etc,
> but I think that CONFIG_ is redundant here.
>
OK, I didn't know what one is more typical. Doing a loose grep for
"^<tab><space><space>" and "[A-Z]_[A-Z]" (excluding CONFIG_) seems like there
are more help text lines that mention other config options (~622) than include
the CONFIG (174). I will change it
> > + If unsure, say N.
> > +
> > +config NULL_TTY_DEFAULT_CONSOLE
> > + bool "Support for console on ttynull"
> > + depends on NULL_TTY=y && !VT_CONSOLE
> > + help
> > + Say Y here if you want the NULL TTY to be used as a /dev/console
> > + device.
> > +
> > + This is similar to CONFIG_VT_CONSOLE, but without the dependency on
> > + CONFIG_VT. It uses the ttynull driver as the system console.
>
> Btw, do those `make nconfig` and friends render the options?
Seems like `make nconfig` works, as well as `make xconfig` I will attempt to
attach a png screenshot.
>
> > If unsure, say N.
>
>
Download attachment "CONFIG_NULL_TTY_DEFAULT_CONSOLE.png" of type "image/png" (115284 bytes)
Powered by blists - more mailing lists