[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAMeQTsaNfQJ=OgWXwQ2bAxa1xbbQxAWDYEcokQ3VJE_EApPbzQ@mail.gmail.com>
Date: Fri, 7 Mar 2025 14:28:21 +0100
From: Patrik Jakobsson <patrik.r.jakobsson@...il.com>
To: linux@...blig.org
Cc: maarten.lankhorst@...ux.intel.com, mripard@...nel.org, tzimmermann@...e.de,
airlied@...il.com, simona@...ll.ch, dri-devel@...ts.freedesktop.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] drm/gma500: Remove unused mrst_clock_funcs
On Thu, Mar 6, 2025 at 4:52 PM <linux@...blig.org> wrote:
>
> From: "Dr. David Alan Gilbert" <linux@...blig.org>
>
> The mrst_clock_funcs const was added in 2013 by
> commit ac6113ebb70d ("drm/gma500/mrst: Add SDVO clock calculation")
> and commented as 'Not used yet'.
>
> It's not been used since, so remove it.
> The helper functions it points to are still used elsewhere.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@...blig.org>
Applied to drm-misc-next
Thanks
> ---
> v2
> commit message fixed to use correct struct name, and add
> note about the functions used still being used.
>
> drivers/gpu/drm/gma500/oaktrail_crtc.c | 7 -------
> 1 file changed, 7 deletions(-)
>
> diff --git a/drivers/gpu/drm/gma500/oaktrail_crtc.c b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> index de8ccfe9890f..ea9b41af0867 100644
> --- a/drivers/gpu/drm/gma500/oaktrail_crtc.c
> +++ b/drivers/gpu/drm/gma500/oaktrail_crtc.c
> @@ -658,10 +658,3 @@ const struct drm_crtc_helper_funcs oaktrail_helper_funcs = {
> .prepare = gma_crtc_prepare,
> .commit = gma_crtc_commit,
> };
> -
> -/* Not used yet */
> -const struct gma_clock_funcs mrst_clock_funcs = {
> - .clock = mrst_lvds_clock,
> - .limit = mrst_limit,
> - .pll_is_valid = gma_pll_is_valid,
> -};
> --
> 2.48.1
>
Powered by blists - more mailing lists