linux-kernel - Re: [PATCH net] ipvs: prevent integer overflow in do_ip_vs_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <rp565ps2-86qn-0806-qpss-314qr3r0n700@vanv.qr>
Date: Fri, 7 Mar 2025 15:06:38 +0100 (CET)
From: Jan Engelhardt <ej@...i.de>
To: Dan Carpenter <dan.carpenter@...aro.org>
cc: "Gustavo A. R. Silva" <gustavo@...eddedor.com>, 
    Simon Horman <horms@...ge.net.au>, Julian Anastasov <ja@....bg>, 
    Pablo Neira Ayuso <pablo@...filter.org>, 
    Jozsef Kadlecsik <kadlec@...filter.org>, 
    "David S. Miller" <davem@...emloft.net>, 
    Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, 
    Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org, 
    lvs-devel@...r.kernel.org, netfilter-devel@...r.kernel.org, 
    coreteam@...filter.org, linux-kernel@...r.kernel.org, 
    kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] ipvs: prevent integer overflow in
 do_ip_vs_get_ctl()


On Friday 2025-03-07 14:44, Dan Carpenter wrote:
> 	case IP_VS_SO_GET_SERVICES:
> 	{
> 		struct ip_vs_get_services *get;
>-		int size;
>+		size_t size;
> 
> 		get = (struct ip_vs_get_services *)arg;
> 		size = struct_size(get, entrytable, get->num_services);
> 		if (*len != size) {
>-			pr_err("length: %u != %u\n", *len, size);
>+			pr_err("length: %u != %lu\n", *len, size);

size_t wants %z not %l.