linux-kernel - Re: [RESEND][PATCH] power: energy_model: Rework the depends on for CONFIG_ENERGY

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jH3Kp0KfX9Ef6OhrJ8-_i_RibvFqWPptHK4my-jvYHCA@mail.gmail.com>
Date: Fri, 7 Mar 2025 15:25:12 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Lukasz Luba <lukasz.luba@....com>
Cc: linux-kernel@...r.kernel.org, linux-pm@...r.kernel.org, rafael@...nel.org, 
	daniel.lezcano@...aro.org, rui.zhang@...el.com, 
	srinivas.pandruvada@...ux.intel.com, jeson.gao@...soc.com
Subject: Re: [RESEND][PATCH] power: energy_model: Rework the depends on for CONFIG_ENERGY_MODEL

On Fri, Mar 7, 2025 at 2:27 PM Lukasz Luba <lukasz.luba@....com> wrote:
>
> From: Jeson Gao <jeson.gao@...soc.com>
>
> Now not only CPUs can use energy efficiency models, but GPUs
> can also use. On the other hand, even with only one CPU, we can also
> use energy_model to align control in thermal.
> So remove the dependence of SMP, and add the DEVFREQ.
>
> Signed-off-by: Jeson Gao <jeson.gao@...soc.com>
> [Added missing SMP config option in DTPM_CPU dependency]
> Signed-off-by: Lukasz Luba <lukasz.luba@....com>
> ---
>
> Hi Rafael,
>
> This fixes the issue in the former patch with the DTMP_CPU
> implicit build dependencies on SMP.
> The original patch can be found here [1] (the one that you had to revert).
>
> Regards,
> Lukasz Luba
>
> [1] https://lore.kernel.org/lkml/20241219091109.10050-1-xuewen.yan@unisoc.com/
>
>
>  drivers/powercap/Kconfig | 2 +-
>  kernel/power/Kconfig     | 3 +--
>  2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/powercap/Kconfig b/drivers/powercap/Kconfig
> index 69ef8d081c98b..03c4c796d9931 100644
> --- a/drivers/powercap/Kconfig
> +++ b/drivers/powercap/Kconfig
> @@ -82,7 +82,7 @@ config DTPM
>
>  config DTPM_CPU
>         bool "Add CPU power capping based on the energy model"
> -       depends on DTPM && ENERGY_MODEL
> +       depends on DTPM && ENERGY_MODEL && SMP
>         help
>           This enables support for CPU power limitation based on
>           energy model.
> diff --git a/kernel/power/Kconfig b/kernel/power/Kconfig
> index ca947ed32e3dd..54a6236800194 100644
> --- a/kernel/power/Kconfig
> +++ b/kernel/power/Kconfig
> @@ -380,8 +380,7 @@ config CPU_PM
>
>  config ENERGY_MODEL
>         bool "Energy Model for devices with DVFS (CPUs, GPUs, etc)"
> -       depends on SMP
> -       depends on CPU_FREQ
> +       depends on CPU_FREQ || PM_DEVFREQ
>         help
>           Several subsystems (thermal and/or the task scheduler for example)
>           can leverage information about the energy consumed by devices to
> --

Applied as 6.15 material, thanks!