linux-kernel - Re: [PATCH] x86/microcode/AMD: Fix out-of-bounds on systems with CPU-less NUMA nodes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2cf9798f-1a89-46e1-b1a4-7deec9cb7e40@intel.com>
Date: Fri, 7 Mar 2025 06:56:03 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Florent Revest <revest@...omium.org>, bp@...en8.de,
 linux-kernel@...r.kernel.org
Cc: tglx@...utronix.de, mingo@...hat.com, dave.hansen@...ux.intel.com,
 x86@...nel.org, hpa@...or.com, stable@...r.kernel.org
Subject: Re: [PATCH] x86/microcode/AMD: Fix out-of-bounds on systems with
 CPU-less NUMA nodes

On 3/7/25 05:12, Florent Revest wrote:
>  	for_each_node(nid) {
> -		cpu = cpumask_first(cpumask_of_node(nid));
> +		mask = cpumask_of_node(nid);
> +		if (cpumask_empty(mask))
> +			continue;
> +
> +		cpu = cpumask_first(mask);

Would for_each_node_with_cpus() trim this down a bit?