linux-kernel - Re: [PATCH v2 8/8] include/{topology,cpuset}: Move dl_rebuild_rd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <234d750d-cd2e-43b2-8133-43ca1fd889de@redhat.com>
Date: Fri, 7 Mar 2025 10:17:03 -0500
From: Waiman Long <llong@...hat.com>
To: Juri Lelli <juri.lelli@...hat.com>, linux-kernel@...r.kernel.org,
 cgroups@...r.kernel.org
Cc: Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
 Vincent Guittot <vincent.guittot@...aro.org>,
 Dietmar Eggemann <dietmar.eggemann@....com>,
 Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
 Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
 Tejun Heo <tj@...nel.org>, Johannes Weiner <hannes@...xchg.org>,
 Michal Koutný <mkoutny@...e.com>,
 Qais Yousef <qyousef@...alina.io>,
 Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 Swapnil Sapkal <swapnil.sapkal@....com>,
 Shrikanth Hegde <sshegde@...ux.ibm.com>, Phil Auld <pauld@...hat.com>,
 luca.abeni@...tannapisa.it, tommaso.cucinotta@...tannapisa.it,
 Jon Hunter <jonathanh@...dia.com>, Waiman Long <llong@...hat.com>
Subject: Re: [PATCH v2 8/8] include/{topology,cpuset}: Move
 dl_rebuild_rd_accounting to cpuset.h


On 3/6/25 9:10 AM, Juri Lelli wrote:
> dl_rebuild_rd_accounting() is defined in cpuset.c, so it makes more
> sense to move related declarations to cpuset.h.
>
> Implement the move.
>
> Suggested-by: Waiman Long <llong@...hat.com>
> Signed-off-by: Juri Lelli <juri.lelli@...hat.com>
> ---
>   include/linux/cpuset.h         | 5 +++++
>   include/linux/sched/topology.h | 2 --
>   2 files changed, 5 insertions(+), 2 deletions(-)
>
> diff --git a/include/linux/cpuset.h b/include/linux/cpuset.h
> index 835e7b793f6a..c414daa7d503 100644
> --- a/include/linux/cpuset.h
> +++ b/include/linux/cpuset.h
> @@ -125,6 +125,7 @@ static inline int cpuset_do_page_mem_spread(void)
>   
>   extern bool current_cpuset_is_being_rebound(void);
>   
> +extern void dl_rebuild_rd_accounting(void);
>   extern void rebuild_sched_domains(void);
>   
>   extern void cpuset_print_current_mems_allowed(void);
> @@ -259,6 +260,10 @@ static inline bool current_cpuset_is_being_rebound(void)
>   	return false;
>   }
>   
> +static inline void dl_rebuild_rd_accounting(void)
> +{
> +}
> +
>   static inline void rebuild_sched_domains(void)
>   {
>   	partition_sched_domains(1, NULL, NULL);
> diff --git a/include/linux/sched/topology.h b/include/linux/sched/topology.h
> index 96e69bfc3c8a..51f7b8169515 100644
> --- a/include/linux/sched/topology.h
> +++ b/include/linux/sched/topology.h
> @@ -166,8 +166,6 @@ static inline struct cpumask *sched_domain_span(struct sched_domain *sd)
>   	return to_cpumask(sd->span);
>   }
>   
> -extern void dl_rebuild_rd_accounting(void);
> -
>   extern void partition_sched_domains(int ndoms_new, cpumask_var_t doms_new[],
>   				    struct sched_domain_attr *dattr_new);
>   
Reviewed-by: Waiman Long <llong@...hat.com>