linux-kernel - Re: [PATCH 01/14] ASoC: mediatek: common: modify mtk afe common driver for mt8196

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8a855e37-b7cf-41ef-8d97-f2ff506a5750@kernel.org>
Date: Fri, 7 Mar 2025 16:20:48 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Darren.Ye" <darren.ye@...iatek.com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 01/14] ASoC: mediatek: common: modify mtk afe common
 driver for mt8196

On 07/03/2025 13:47, Darren.Ye wrote:
> From: Darren Ye <darren.ye@...iatek.com>
> 
> Export register read and write interface, add sample reate interface, and
> update the mtk_memif_set_channel interface for the mt8196 platform.
> 
> Signed-off-by: Darren Ye <darren.ye@...iatek.com>
> ---
>  sound/soc/mediatek/common/mtk-afe-fe-dai.c | 30 ++++++++++++++--------
>  sound/soc/mediatek/common/mtk-afe-fe-dai.h |  6 +++++
>  sound/soc/mediatek/common/mtk-base-afe.h   | 13 ++++++++++
>  3 files changed, 38 insertions(+), 11 deletions(-)
> 
> diff --git a/sound/soc/mediatek/common/mtk-afe-fe-dai.c b/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> index 3809068f5620..c36dae520f04 100644
> --- a/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> +++ b/sound/soc/mediatek/common/mtk-afe-fe-dai.c
> @@ -18,7 +18,7 @@
>  
>  #define AFE_BASE_END_OFFSET 8
>  
> -static int mtk_regmap_update_bits(struct regmap *map, int reg,
> +int mtk_regmap_update_bits(struct regmap *map, int reg,

You need kerneldoc for all exported functions.

>  			   unsigned int mask,
>  			   unsigned int val, int shift)
>  {
> @@ -26,13 +26,16 @@ static int mtk_regmap_update_bits(struct regmap *map, int reg,
>  		return 0;
>  	return regmap_update_bits(map, reg, mask << shift, val << shift);
>  }
> +EXPORT_SYMBOL(mtk_regmap_update_bits);

GPL


> +
> +int mtk_regmap_write(struct regmap *map, int reg, unsigned int val)
>  

Why blank line?

> -static int mtk_regmap_write(struct regmap *map, int reg, unsigned int val)

Missing kerneldoc

>  {
>  	if (reg < 0)
>  		return 0;
>  	return regmap_write(map, reg, val);
>  }
> +EXPORT_SYMBOL(mtk_regmap_write);

GPL


Best regards,
Krzysztof