linux-kernel - Re: [PATCH 10/14] ASoC: mediatek: mt8196: support CM in platform driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <40bb42ca-52f5-4579-a9c7-58e6ff5dbbb5@kernel.org>
Date: Fri, 7 Mar 2025 16:33:22 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: "Darren.Ye" <darren.ye@...iatek.com>, Liam Girdwood
 <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Matthias Brugger
 <matthias.bgg@...il.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
 Linus Walleij <linus.walleij@...aro.org>, Bartosz Golaszewski <brgl@...ev.pl>
Cc: linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
 linux-mediatek@...ts.infradead.org, linux-gpio@...r.kernel.org
Subject: Re: [PATCH 10/14] ASoC: mediatek: mt8196: support CM in platform
 driver

On 07/03/2025 13:47, Darren.Ye wrote:
> +int mt8196_enable_cm_bypass(struct mtk_base_afe *afe, int id, bool en)
> +{
> +	int reg = AFE_CM0_CON0 + 0x10 * id;
> +
> +	mtk_regmap_update_bits(afe->regmap, reg, AFE_CM_BYPASS_MODE_MASK,
> +			       en, AFE_CM_BYPASS_MODE_SFT);
> +
> +	return 0;
> +}
> +EXPORT_SYMBOL_GPL(mt8196_enable_cm_bypass);
> +
> +MODULE_DESCRIPTION("Mediatek afe cm");
> +MODULE_AUTHOR("darren ye <darren.ye@...iatek.com>");
> +MODULE_LICENSE("GPL");

If this is module, where is Makefile and Kconfig?

All previous comments about missing kerneldoc also apply.

Best regards,
Krzysztof