linux-kernel - Re: [PATCH 01/21] mtd: spinand: Use more specific naming for the reset op

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87v7skrgjl.fsf@bootlin.com>
Date: Fri, 07 Mar 2025 16:45:02 +0100
From: Miquel Raynal <miquel.raynal@...tlin.com>
To: Tudor Ambarus <tudor.ambarus@...aro.org>
Cc: Richard Weinberger <richard@....at>,  Vignesh Raghavendra
 <vigneshr@...com>,  Santhosh Kumar K <s-k6@...com>,  Pratyush Yadav
 <pratyush@...nel.org>,  Michael Walle <michael@...le.cc>,  Thomas
 Petazzoni <thomas.petazzoni@...tlin.com>,  Steam Lin <stlin2@...bond.com>,
  linux-mtd@...ts.infradead.org,  linux-kernel@...r.kernel.org
Subject: Re: [PATCH 01/21] mtd: spinand: Use more specific naming for the
 reset op

Hi Tudor,

>> -#define SPINAND_RESET_OP						\
>> +#define SPINAND_RESET_1S_0_0_OP						\
> Hi, Miquel,
>
> Have you seen any reset op with address or data? If not, I'm not really
> sure whether we shall change the name for these basic operations.
>
> Changing them to 1S-0-0 may also indicate that there are resets with
> address or data fields, which I find confusing.
>
> I think the change is good for reads and writes. I'll check further in
> the series and let you know.

I want to rename this macro for two reasons:
- We might see in the near future the addition of 8D-0-0 ops (I plan on
  working on it).
- I would like some kind of harmony among these macros.

Now, whether is should be named like I proposed or just
SPINAND_RESET_OP_1S, I have no strong preference and I can change that
in an upcoming version.

Which one would you prefer?

Cheers,
Miquèl