linux-kernel - Re: [PATCH 1/2] drm/msm/dpu: correct dpu_crtc_check_mode

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAF6AEGv9ViJtvnYM-n-+oHY_Ky7KvBtng_2EOBDtyTL53SB_hA@mail.gmail.com>
Date: Fri, 7 Mar 2025 08:01:44 -0800
From: Rob Clark <robdclark@...il.com>
To: Dmitry Baryshkov <lumag@...nel.org>
Cc: Abhinav Kumar <quic_abhinavk@...cinc.com>, 
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>, Sean Paul <sean@...rly.run>, 
	Marijn Suijten <marijn.suijten@...ainline.org>, David Airlie <airlied@...il.com>, 
	Simona Vetter <simona@...ll.ch>, Jessica Zhang <quic_jesszhan@...cinc.com>, 
	linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org, 
	freedreno@...ts.freedesktop.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] drm/msm/dpu: correct dpu_crtc_check_mode_changed docs

On Thu, Mar 6, 2025 at 12:22 AM Dmitry Baryshkov <lumag@...nel.org> wrote:
>
> Correct commit 20972609d12c ("drm/msm/dpu: Require modeset if clone mode
> status changes") and describe old_crtc_state and new_crtc_state params
> instead of the single previously used parameter crtc_state.
>
> Fixes: 20972609d12c ("drm/msm/dpu: Require modeset if clone mode status changes")
> Signed-off-by: Dmitry Baryshkov <lumag@...nel.org>

Reviewed-by: Rob Clark <robdclark@...il.com>

> ---
>  drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> index b0a062d6fa3bf942ffd687a91bccac3aa4f06f02..536d15818ba24f8b11f24e3bd9726d31c57ef531 100644
> --- a/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> +++ b/drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c
> @@ -1395,7 +1395,8 @@ static int dpu_crtc_assign_resources(struct drm_crtc *crtc,
>
>  /**
>   * dpu_crtc_check_mode_changed: check if full modeset is required
> - * @crtc_state:        Corresponding CRTC state to be checked
> + * @old_crtc_state:    Previous CRTC state
> + * @new_crtc_state:    Corresponding CRTC state to be checked
>   *
>   * Check if the changes in the object properties demand full mode set.
>   */
>
> --
> 2.39.5
>