linux-kernel - Re: [PATCH v9 5/6] scanf: tidy header `#include`s

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8suJdZsLYPYF34t@smile.fi.intel.com>
Date: Fri, 7 Mar 2025 19:34:29 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Tamir Duberstein <tamird@...il.com>
Cc: David Gow <davidgow@...gle.com>, Petr Mladek <pmladek@...e.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	Rasmus Villemoes <linux@...musvillemoes.dk>,
	Sergey Senozhatsky <senozhatsky@...omium.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Shuah Khan <shuah@...nel.org>,
	Geert Uytterhoeven <geert@...ux-m68k.org>,
	linux-kernel@...r.kernel.org, linux-kselftest@...r.kernel.org
Subject: Re: [PATCH v9 5/6] scanf: tidy header `#include`s

On Fri, Mar 07, 2025 at 06:27:38AM -0500, Tamir Duberstein wrote:
> Remove the unused `kernel.h`. Replace `string.h` with `sprintf.h` as the
> former doesn't seem to be used directly.

...

>  #include <kunit/test.h>

+ array_size.h

>  #include <linux/bitops.h>

+ bug.h // BUILD_BUG_ON()
+ errno.h // actually asm/errno.h, but in C code the linux/* will suffice

> -#include <linux/kernel.h>

This was used like a "proxy" header to a lot, see around.

>  #include <linux/module.h>
>  #include <linux/overflow.h>
>  #include <linux/prandom.h>
>  #include <linux/slab.h>
> -#include <linux/string.h>
> +#include <linux/sprintf.h>

+ types.h // u32, __scanf, ...

...

Note,the above I made based on the context of your changes, I haven't checked
the resulting file in full, please do it yourself.

-- 
With Best Regards,
Andy Shevchenko