linux-kernel - Re: [PATCH] PCI: controller: Restore PCI_REASSIGN_ALL_BUS when PCI_PROBE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250307174839.7nd7mhc5ebmokumu@thinkpad>
Date: Fri, 7 Mar 2025 23:18:39 +0530
From: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
To: Bo Sun <Bo.Sun.CN@...driver.com>
Cc: Manivannan Sadhasivam <mani@...nel.org>, Kexin.Hao@...driver.com,
	linux-pci@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org, stable@...r.kernel.org,
	Will Deacon <will@...nel.org>,
	Lorenzo Pieralisi <lpieralisi@...nel.org>,
	Krzysztof Wilczyński <kw@...ux.com>,
	Rob Herring <robh@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>,
	Vidya Sagar <vidyas@...dia.com>
Subject: Re: [PATCH] PCI: controller: Restore PCI_REASSIGN_ALL_BUS when
 PCI_PROBE_ONLY is enabled

On Fri, Mar 07, 2025 at 06:14:26PM +0800, Bo Sun wrote:

[...]

> > > So, I propose the following solution as a workaround to handle these edge
> > > cases.
> > > 
> > > diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
> > > index 82b21e34c545..af8efebc7e7d 100644
> > > --- a/drivers/pci/quirks.c
> > > +++ b/drivers/pci/quirks.c
> > > @@ -6181,6 +6181,13 @@ DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1536,
> > > rom_bar_overlap_defect);
> > >   DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1537,
> > > rom_bar_overlap_defect);
> > >   DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x1538,
> > > rom_bar_overlap_defect);
> > > 
> > > +static void quirk_marvell_cn96xx_cn10xxx_reassign_all_busnr(struct pci_dev
> > > *dev)
> > > +{
> > > +       if (!pci_has_flag(PCI_PROBE_ONLY))
> > > +               pci_add_flags(PCI_REASSIGN_ALL_BUS);
> > > +}
> > > +DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_CAVIUM, 0xa002,
> > > quirk_marvell_cn96xx_cn10xxx_reassign_all_busnr);
> > > +
> > 
> > LGTM. Please add a comment about this quirk too.
> 
> OK, I'll add the comment. Should I send the v2 patch?
> 

Yes, ofc. You should send v2 with the quirk change.

- Mani

-- 
மணிவண்ணன் சதாசிவம்