linux-kernel - Re: [PATCH] net: fix uninitialised access in mii_nway

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <9242fedf-3450-4d6e-b08d-846956f2cb9d@lunn.ch>
Date: Fri, 7 Mar 2025 18:56:20 +0100
From: Andrew Lunn <andrew@...n.ch>
To: Qasim Ijaz <qasdev00@...il.com>
Cc: davem@...emloft.net, edumazet@...gle.com, kuba@...nel.org,
	pabeni@...hat.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org,
	syzbot+3361c2d6f78a3e0892f9@...kaller.appspotmail.com,
	stable@...r.kernel.org
Subject: Re: [PATCH] net: fix uninitialised access in mii_nway_restart()

> Hi Andrew,
> 
> Just following up on my patch regarding the uninitialized access fix in mii_nway_restart(). 
> As I mentioned in my previous message, how about an approach similar to the patch for ch9200_mdio_read() 
> for get_mac_address() where we immediately check the return value of each control_read() call and return 
> an error if any call fails? This way we don't continue if failure occurs. If you're good with this approach, 
> should I submit a patch v2?

Yes, this would be good.

Thanks
	Andrew