linux-kernel - Re: [PATCH v3 05/10] x86/fpu/xstate: Introduce guest FPU configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cde2e31a-af2b-4236-a5b7-e1119c62b4a5@intel.com>
Date: Fri, 7 Mar 2025 10:06:56 -0800
From: Dave Hansen <dave.hansen@...el.com>
To: Chao Gao <chao.gao@...el.com>, tglx@...utronix.de, x86@...nel.org,
 seanjc@...gle.com, pbonzini@...hat.com, linux-kernel@...r.kernel.org,
 kvm@...r.kernel.org
Cc: peterz@...radead.org, rick.p.edgecombe@...el.com,
 weijiang.yang@...el.com, john.allen@....com, bp@...en8.de,
 Maxim Levitsky <mlevitsk@...hat.com>
Subject: Re: [PATCH v3 05/10] x86/fpu/xstate: Introduce guest FPU
 configuration

On 3/7/25 08:41, Chao Gao wrote:
> +	fpu_guest_cfg.max_features = fpu_kernel_cfg.max_features;
> +	fpu_guest_cfg.default_features = fpu_guest_cfg.max_features;
> +	fpu_guest_cfg.default_features &= ~XFEATURE_MASK_USER_DYNAMIC;

Is just copying and pasting the 'fpu_kernel_cfg' initialization really
the best way to explain what's going on?

Let's say you just did:

	fpu_guest_cfg = fpu_kernel_cfg;

?

That would explicitly tell the reader that they're equal.