linux-kernel - Re: [PATCH] media: pci: mgb4: include linux/errno.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d46f9862-ecb2-4e8c-86de-7dcc31bb77d1@gpxsee.org>
Date: Fri, 7 Mar 2025 19:27:16 +0100
From: Martin Tůma <tumic@...see.org>
To: Arnd Bergmann <arnd@...nel.org>,
 Martin Tuma <martin.tuma@...iteqautomotive.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>
Cc: Arnd Bergmann <arnd@...db.de>, Ricardo Ribalda <ribalda@...omium.org>,
 Bryan O'Donoghue <bryan.odonoghue@...aro.org>, linux-media@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] media: pci: mgb4: include linux/errno.h

On 07. 03. 25 11:24 dop., Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The errno.h header is not always included indirectly, leading
> to rare randconfig build warnings.
> 
> drivers/media/pci/mgb4/mgb4_regs.c:20:11: error: use of undeclared identifier 'EINVAL'
>     20 |                 return -EINVAL;
> 
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>   drivers/media/pci/mgb4/mgb4_regs.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/media/pci/mgb4/mgb4_regs.c b/drivers/media/pci/mgb4/mgb4_regs.c
> index 31befd722d72..b45537dbfafa 100644
> --- a/drivers/media/pci/mgb4/mgb4_regs.c
> +++ b/drivers/media/pci/mgb4/mgb4_regs.c
> @@ -5,6 +5,7 @@
>    */
>   
>   #include <linux/ioport.h>
> +#include <linux/errno.h>
>   #include "mgb4_regs.h"
>   
>   int mgb4_regs_map(struct resource *res, struct mgb4_regs *regs)

Acked-by: Martin Tůma <martin.tuma@...iteqautomotive.com>