linux-kernel - Re: [PATCH v12 17/19] tpm, sysfs: Show locality used by kernel

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202d0759-579d-417a-b532-27ffe69316cf@oracle.com>
Date: Fri, 7 Mar 2025 11:39:22 -0800
From: ross.philipson@...cle.com
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: linux-kernel@...r.kernel.org, x86@...nel.org,
        linux-integrity@...r.kernel.org, linux-doc@...r.kernel.org,
        linux-crypto@...r.kernel.org, kexec@...ts.infradead.org,
        linux-efi@...r.kernel.org, iommu@...ts.linux-foundation.org,
        dpsmith@...rtussolutions.com, tglx@...utronix.de, mingo@...hat.com,
        bp@...en8.de, hpa@...or.com, dave.hansen@...ux.intel.com,
        ardb@...nel.org, mjg59@...f.ucam.org,
        James.Bottomley@...senpartnership.com, peterhuewe@....de, jgg@...pe.ca,
        luto@...capital.net, nivedita@...m.mit.edu,
        herbert@...dor.apana.org.au, davem@...emloft.net, corbet@....net,
        ebiederm@...ssion.com, dwmw2@...radead.org, baolu.lu@...ux.intel.com,
        kanth.ghatraju@...cle.com, andrew.cooper3@...rix.com,
        trenchboot-devel@...glegroups.com
Subject: Re: [PATCH v12 17/19] tpm, sysfs: Show locality used by kernel

On 3/6/25 11:09 PM, Jarkko Sakkinen wrote:
> On Thu, Dec 19, 2024 at 11:42:14AM -0800, Ross Philipson wrote:
>> Expose the locality used by the kernel to sysfs.
>>
>> Signed-off-by: Ross Philipson <ross.philipson@...cle.com>
>> Signed-off-by: Jarkko Sakkinen <jarkko@...nel.org>
>> ---
>>   drivers/char/tpm/tpm-sysfs.c | 10 ++++++++++
>>   1 file changed, 10 insertions(+)
>>
>> diff --git a/drivers/char/tpm/tpm-sysfs.c b/drivers/char/tpm/tpm-sysfs.c
>> index 94231f052ea7..2da5857e223b 100644
>> --- a/drivers/char/tpm/tpm-sysfs.c
>> +++ b/drivers/char/tpm/tpm-sysfs.c
>> @@ -309,6 +309,14 @@ static ssize_t tpm_version_major_show(struct device *dev,
>>   }
>>   static DEVICE_ATTR_RO(tpm_version_major);
>>   
>> +static ssize_t locality_show(struct device *dev, struct device_attribute *attr, char *buf)
>> +{
>> +	struct tpm_chip *chip = to_tpm_chip(dev);
>> +
>> +	return sprintf(buf, "%u\n", chip->kernel_locality);
>> +}
>> +static DEVICE_ATTR_RO(locality);
>> +
>>   #ifdef CONFIG_TCG_TPM2_HMAC
>>   static ssize_t null_name_show(struct device *dev, struct device_attribute *attr,
>>   			      char *buf)
>> @@ -336,6 +344,7 @@ static struct attribute *tpm1_dev_attrs[] = {
>>   	&dev_attr_durations.attr,
>>   	&dev_attr_timeouts.attr,
>>   	&dev_attr_tpm_version_major.attr,
>> +	&dev_attr_locality.attr,
>>   	NULL,
>>   };
>>   
>> @@ -344,6 +353,7 @@ static struct attribute *tpm2_dev_attrs[] = {
>>   #ifdef CONFIG_TCG_TPM2_HMAC
>>   	&dev_attr_null_name.attr,
>>   #endif
>> +	&dev_attr_locality.attr,
>>   	NULL
>>   };
>>   
>> -- 
>> 2.39.3
>>
> 
> I think we are now in good standing point with TPM changes.
> 
> I'd really put focus now on unimportant seeming but actually important
> documentation full refinement. It has all the infos but it is torture
> to read still :-) I did put detail how I would like it to be edited
> (personally, perhaps others could comment that part too). If it was
> a bit more punctual it would be easier to follow rest of the patch
> set.

Yes this is very fair. We can do a scrub of all documentation including 
commit messages and comments. We will incorporate your and other folk's 
input in the process.

Thank you for taking the time to look through these patches. I know 
people are busy, we really appreciate it.

Ross

> 
> BR, Jarkko