linux-kernel - Re: [PATCH net-next v1 3/4] net: add granular lock for the netdev netlink socket

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250307153456.7c698a1a@kernel.org>
Date: Fri, 7 Mar 2025 15:34:56 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Stanislav Fomichev <sdf@...ichev.me>
Cc: netdev@...r.kernel.org, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, linux-kernel@...r.kernel.org, horms@...nel.org,
 donald.hunter@...il.com, michael.chan@...adcom.com,
 pavan.chebbi@...adcom.com, andrew+netdev@...n.ch, jdamato@...tly.com,
 xuanzhuo@...ux.alibaba.com, almasrymina@...gle.com, asml.silence@...il.com,
 dw@...idwei.uk
Subject: Re: [PATCH net-next v1 3/4] net: add granular lock for the netdev
 netlink socket

On Fri,  7 Mar 2025 07:57:24 -0800 Stanislav Fomichev wrote:
> diff --git a/net/core/netdev-genl.c b/net/core/netdev-genl.c
> index a219be90c739..8acdeeae24e7 100644
> --- a/net/core/netdev-genl.c
> +++ b/net/core/netdev-genl.c
> @@ -859,6 +859,7 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)
>  		goto err_genlmsg_free;
>  	}
>  
> +	mutex_lock(&priv->lock);
>  	rtnl_lock();
>  
>  	netdev = __dev_get_by_index(genl_info_net(info), ifindex);
> @@ -925,6 +926,7 @@ int netdev_nl_bind_rx_doit(struct sk_buff *skb, struct genl_info *info)
>  	net_devmem_unbind_dmabuf(binding);
>  err_unlock:
>  	rtnl_unlock();
> +	mutex_unlock(&priv->lock);
>  err_genlmsg_free:
>  	nlmsg_free(rsp);
>  	return err;

I think you're missing an unlock before successful return here no?