linux-kernel - Re: [RFC]: Getting ADIS16203 out of staging

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z8pozuvS1a3sa039@debian-BULLSEYE-live-builder-AMD64>
Date: Fri, 7 Mar 2025 00:32:30 -0300
From: Marcelo Schmitt <marcelo.schmitt1@...il.com>
To: Saalim Quadri <danascape@...il.com>
Cc: jic23@...nel.org, lars@...afoo.de, Michael.Hennerich@...log.com,
	gregkh@...uxfoundation.org, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org, linux-staging@...ts.linux.dev
Subject: Re: [RFC]: Getting ADIS16203 out of staging

Hi Saalim,

On 03/06, Saalim Quadri wrote:
> ADIS16203 and ADIS16201 are very similar in functionality whilst the
> major difference between the accuracy in ADIS16201, I wonder if they
> can be merged together into single driver, whilst also implementing
> platform_device support in them.
> 
>From quick datasheet comparison, yes, I think the drivers could be merged.

> I want to work on this, provided some opinions for me to work with
> or to have a separate driver for both of them.

I often look at two things when assessing if two or more devices can be
supported by the same driver, the protocol and internal register structure. For
IIO devices, the protocol is usually I2C or SPI. Though, even between devices of
same protocol, there may be differences on how the data is structured in
read/write commands. Also, if internal registers have very different addresses
or meanings, it makes it harder to reuse code because the configuration
procedure for each distinct design/device will tend to require specific
handling.

That said, ADIS16201 and ADIS16203 SPI read/write commands seem to be the same,
and ADIS16203 registers seem to be a subset of ADIS16201's. That's why I think
it may be worth merging the drivers. I didn't read the datasheets thoroughly,
though.

> 
> I see that there has been some discussion regarding the same at [1].
> 
> [1]: https://lore.kernel.org/linux-iio/20230124094450.0000272b@Huawei.com

Git tends to rename/move files when we move a file from one directory to another.
IIRC, Jonathan prefers the drivers to be completely removed from staging to then
be added under iio directory to sort of make it clearer that something is
being added to official (not staging) IIO drivers. To accomplish that, we
use --no-renames flag (e.g. git format-patch --no-renames ...).

> 
> Sincerely,
> Saalim Quadri
>