linux-kernel - RE: [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for PFs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <CY8PR12MB7195A3B7FEB628BEB03C7B7EDCD52@CY8PR12MB7195.namprd12.prod.outlook.com>
Date: Fri, 7 Mar 2025 03:41:28 +0000
From: Parav Pandit <parav@...dia.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, Eric
 Dumazet <edumazet@...gle.com>, Andrew Lunn <andrew+netdev@...n.ch>
CC: Saeed Mahameed <saeedm@...dia.com>, Gal Pressman <gal@...dia.com>, Leon
 Romanovsky <leonro@...dia.com>, Mark Bloch <mbloch@...dia.com>, Jiri Pirko
	<jiri@...nulli.us>, Leon Romanovsky <leon@...nel.org>, Tariq Toukan
	<tariqt@...dia.com>, "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
	"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, Jiri Pirko
	<jiri@...dia.com>, Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
Subject: RE: [PATCH net RESEND] net/mlx5: Fill out devlink dev info only for
 PFs



> From: Tariq Toukan <tariqt@...dia.com>
> Sent: Friday, March 7, 2025 2:55 AM
> 
> From: Jiri Pirko <jiri@...dia.com>
> 
> Firmware version query is supported on the PFs. Due to this following kernel
> warning log is observed:
> 
> [  188.590344] mlx5_core 0000:08:00.2: mlx5_fw_version_query:816:(pid
> 1453): fw query isn't supported by the FW
> 
> Fix it by restricting the query and devlink info to the PF.
> 
> Fixes: 8338d9378895 ("net/mlx5: Added devlink info callback")
> Signed-off-by: Jiri Pirko <jiri@...dia.com>
> Reviewed-by: Kalesh AP <kalesh-anakkur.purayil@...adcom.com>
> Signed-off-by: Tariq Toukan <tariqt@...dia.com>

Reviewed-by: Parav Pandit <parav@...dia.com>

> ---
>  drivers/net/ethernet/mellanox/mlx5/core/devlink.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> index 98d4306929f3..a2cf3e79693d 100644
> --- a/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> +++ b/drivers/net/ethernet/mellanox/mlx5/core/devlink.c
> @@ -46,6 +46,9 @@ mlx5_devlink_info_get(struct devlink *devlink, struct
> devlink_info_req *req,
>  	u32 running_fw, stored_fw;
>  	int err;
> 
> +	if (!mlx5_core_is_pf(dev))
> +		return 0;
> +
>  	err = devlink_info_version_fixed_put(req, "fw.psid", dev->board_id);
>  	if (err)
>  		return err;
> --
> 2.45.0
>