| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <8318dbc1-1c15-4a11-abba-23f917e8b176@stanley.mountain>
Date: Fri, 7 Mar 2025 10:43:36 +0300
From: Dan Carpenter <dan.carpenter@...aro.org>
To: oe-kbuild@...ts.linux.dev, raoxu <raoxu@...ontech.com>,
mathias.nyman@...el.com, gregkh@...uxfoundation.org
Cc: lkp@...el.com, oe-kbuild-all@...ts.linux.dev, linux-usb@...r.kernel.org,
linux-kernel@...r.kernel.org, wangyuli@...ontech.com,
zhanjun@...ontech.com, Xu Rao <raoxu@...ontech.com>
Subject: Re: [PATCH] From: Xu Rao <raoxu@...ontech.com> Subject: [PATCH] usb:
xhci: Add debugfs support for xHCI port bandwidth
Hi raoxu,
kernel test robot noticed the following build warnings:
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/raoxu/From-Xu-Rao-raoxu-uniontech-com-Subject-PATCH-usb-xhci-Add-debugfs-support-for-xHCI-port-bandwidth/20250303-180107
base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing
patch link: https://lore.kernel.org/r/20250303095837.16332-1-raoxu%40uniontech.com
patch subject: [PATCH] From: Xu Rao <raoxu@...ontech.com> Subject: [PATCH] usb: xhci: Add debugfs support for xHCI port bandwidth
config: riscv-randconfig-r072-20250306 (https://download.01.org/0day-ci/archive/20250307/202503071516.tj5UBRqT-lkp@intel.com/config)
compiler: clang version 17.0.6 (https://github.com/llvm/llvm-project 6009708b4367171ccdbf4b5905cb6a803753fe18)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Reported-by: Dan Carpenter <dan.carpenter@...aro.org>
| Closes: https://lore.kernel.org/r/202503071516.tj5UBRqT-lkp@intel.com/
New smatch warnings:
drivers/usb/host/xhci.c:3120 xhci_get_port_bandwidth() error: uninitialized symbol 'flags'.
Old smatch warnings:
arch/riscv/include/asm/atomic.h:218 arch_atomic_fetch_add_unless() warn: inconsistent indenting
vim +/flags +3120 drivers/usb/host/xhci.c
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3094 int xhci_get_port_bandwidth(struct xhci_hcd *xhci, u8 *bw_table)
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3095 {
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3096 unsigned int num_ports;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3097 unsigned int i;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3098 struct xhci_command *cmd;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3099 dma_addr_t dma_handle;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3100 void *dma_buf;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3101 int ret;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3102 unsigned long flags;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3103 struct device *dev = xhci_to_hcd(xhci)->self.sysdev;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3104
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3105 num_ports = HCS_MAX_PORTS(xhci->hcs_params1);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3106
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3107 cmd = xhci_alloc_command(xhci, true, GFP_KERNEL);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3108 if (!cmd)
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3109 return -ENOMEM;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3110
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3111 dma_buf = dma_alloc_coherent(dev, xhci->page_size, &dma_handle,
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3112 GFP_KERNEL);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3113 if (!dma_buf) {
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3114 xhci_free_command(xhci, cmd);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3115 return -ENOMEM;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3116 }
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3117
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3118 /* get xhci hub usb3 port bandwidth */
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3119 /* refer to xhci rev1_2 protocol 4.6.15*/
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 @3120 spin_unlock_irqrestore(&xhci->lock, flags);
This was supposed to be spin_lock_save().
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3121 ret = xhci_queue_get_rh_port_bw(xhci, cmd, dma_handle, USB_SPEED_SUPER,
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3122 0, false);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3123 if (ret < 0) {
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3124 spin_unlock_irqrestore(&xhci->lock, flags);
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3125 goto out;
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3126 }
01a36d597b1902 drivers/usb/host/xhci.c Xu Rao 2025-03-03 3127 xhci_ring_cmd_db(xhci);
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
Powered by blists - more mailing lists