linux-kernel - Re: [PATCH v2 2/8] sched/topology: Wrappers for sched_domains

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ab67eb4d-0940-4278-b84f-20dbaf0560cf@linux.ibm.com>
Date: Fri, 7 Mar 2025 14:32:35 +0530
From: Shrikanth Hegde <sshegde@...ux.ibm.com>
To: Juri Lelli <juri.lelli@...hat.com>
Cc: linux-kernel@...r.kernel.org, cgroups@...r.kernel.org,
        Ingo Molnar <mingo@...hat.com>, Peter Zijlstra <peterz@...radead.org>,
        Vincent Guittot <vincent.guittot@...aro.org>,
        Dietmar Eggemann <dietmar.eggemann@....com>,
        Steven Rostedt <rostedt@...dmis.org>, Ben Segall <bsegall@...gle.com>,
        Mel Gorman <mgorman@...e.de>, Valentin Schneider <vschneid@...hat.com>,
        Waiman Long <longman@...hat.com>, Tejun Heo <tj@...nel.org>,
        Johannes Weiner <hannes@...xchg.org>,
        Michal Koutný
 <mkoutny@...e.com>,
        Qais Yousef <qyousef@...alina.io>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Swapnil Sapkal <swapnil.sapkal@....com>, Phil Auld <pauld@...hat.com>,
        luca.abeni@...tannapisa.it, tommaso.cucinotta@...tannapisa.it,
        Jon Hunter <jonathanh@...dia.com>
Subject: Re: [PATCH v2 2/8] sched/topology: Wrappers for sched_domains_mutex



On 3/7/25 14:23, Juri Lelli wrote:
> Hi,
> 
> Thanks for the overall review!
> 
> On 07/03/25 12:04, Shrikanth Hegde wrote:
>> Hi Juri.
>>
>> On 3/6/25 19:40, Juri Lelli wrote:
>>> Create wrappers for sched_domains_mutex so that it can transparently be
>>> used on both CONFIG_SMP and !CONFIG_SMP, as some function will need to
>>> do.
> 
> ...
> 
>> Maybe sched_domains_mutex can be static since its only used in topology.c ?
> 
> We have a lockdep_assert in cpuset.c, don't we? We can create another
> wrapper for that, but I am not sure it is going to be cleaner.

Ok. Sorry, my bad. I searched only in kernel/sched. You can ignore this 
comment.

> 
> Thanks,
> Juri
>