linux-kernel - Re: [PATCH] wifi: mwifiex: Constify struct mwifiex_if

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z8q8bleeyyavuNeA@gaggiata.pivistrello.it>
Date: Fri, 7 Mar 2025 10:29:18 +0100
From: Francesco Dolcini <francesco@...cini.it>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Brian Norris <briannorris@...omium.org>,
	Francesco Dolcini <francesco@...cini.it>,
	Kalle Valo <kvalo@...nel.org>, linux-kernel@...r.kernel.org,
	kernel-janitors@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] wifi: mwifiex: Constify struct mwifiex_if_ops

On Sun, Jan 19, 2025 at 06:48:39PM +0100, Christophe JAILLET wrote:
> 'struct mwifiex_if_ops' are not modified in these drivers.
> 
> Constifying these structures moves some data to a read-only section, so
> increase overall security, especially when the structure holds some
> function pointers.
> 
> On a x86_64, with allmodconfig, as an example:
> Before:
> ======
>    text	   data	    bss	    dec	    hex	filename
>   61439	   4367	     32	  65838	  1012e	drivers/net/wireless/marvell/mwifiex/pcie.o
> 
> After:
> =====
>    text	   data	    bss	    dec	    hex	filename
>   61699	   4127	     32	  65858	  10142	drivers/net/wireless/marvell/mwifiex/pcie.o
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Reviewed-by: Francesco Dolcini <francesco.dolcini@...adex.com>

> Compile tested-only.
I did also a brief smoke test on 88W8997, and the driver just probe fines.

Tested-by: Francesco Dolcini <francesco.dolcini@...adex.com> # Verdin iMX8MM - 88W8997