linux-kernel - Re: [PATCH v2] kunit: tool: Fix bug in parsing test plan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CA+i-1C2RgoRR-46uD+PBP0N5oLcJYDp05iE96QAXfRRz__e-BA@mail.gmail.com>
Date: Fri, 7 Mar 2025 10:54:23 +0100
From: Brendan Jackman <jackmanb@...gle.com>
To: Rae Moar <rmoar@...gle.com>
Cc: shuah@...nel.org, davidgow@...gle.com, linux-kselftest@...r.kernel.org, 
	kunit-dev@...glegroups.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] kunit: tool: Fix bug in parsing test plan

On Thu, 6 Mar 2025 at 19:20, Rae Moar <rmoar@...gle.com> wrote:
>
> A bug was identified where the KTAP below caused an infinite loop:
>
>  TAP version 13
>  ok 4 test_case
>  1..4
>
> The infinite loop was caused by the parser not parsing a test plan
> if following a test result line.
>
> Fix this bug to correctly parse test plan line.
>
> Signed-off-by: Rae Moar <rmoar@...gle.com>

Hi Rae thanks again for taking a look at this. I just noticed
kunit_tool_test.py has unit tests for the parsing logic. Maybe worth
adding one for the case that was infinite looping before?

(I am not really able to offer an actual review as I couldn't really
understand the parsing code after a quick reading, but if you need it
then let me know and I'll chase you up to ask questions until I can
follow it, then I can review!)