linux-kernel - Re: [PATCH 1/2] NFSD: unregister filesystem in case genl_register

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <77acf3fbd9946522d1b18a6e8a05000465b72f40.camel@kernel.org>
Date: Fri, 07 Mar 2025 06:07:47 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Maninder Singh <maninder1.s@...sung.com>, chuck.lever@...cle.com, 
	neilb@...e.de, okorniev@...hat.com, Dai.Ngo@...cle.com, tom@...pey.com, 
	lorenzo@...nel.org
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org, 
	chungki0201.woo@...sung.com
Subject: Re: [PATCH 1/2] NFSD: unregister filesystem in case
 genl_register_family() fails

On Thu, 2025-03-06 at 14:50 +0530, Maninder Singh wrote:
> With rpc_status netlink support, unregister of register_filesystem()
> was missed in case of genl_register_family() fails.
> 
> Correcting it by making new label.
> 
> Fixes: bd9d6a3efa97 ("NFSD: add rpc_status netlink support")
> Signed-off-by: Maninder Singh <maninder1.s@...sung.com>
> ---
>  fs/nfsd/nfsctl.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/nfsd/nfsctl.c b/fs/nfsd/nfsctl.c
> index ac265d6fde35..d773481bcf10 100644
> --- a/fs/nfsd/nfsctl.c
> +++ b/fs/nfsd/nfsctl.c
> @@ -2305,7 +2305,7 @@ static int __init init_nfsd(void)
>  		goto out_free_cld;
>  	retval = register_filesystem(&nfsd_fs_type);
>  	if (retval)
> -		goto out_free_all;
> +		goto out_free_nfsd4;
>  	retval = genl_register_family(&nfsd_nl_family);
>  	if (retval)
>  		goto out_free_all;
> @@ -2313,6 +2313,8 @@ static int __init init_nfsd(void)
>  
>  	return 0;
>  out_free_all:
> +	unregister_filesystem(&nfsd_fs_type);
> +out_free_nfsd4:
>  	nfsd4_destroy_laundry_wq();
>  out_free_cld:
>  	unregister_cld_notifier();

Reviewed-by: Jeff Layton <jlayton@...nel.org>