linux-kernel - Re: [PATCH] clk: mmp: Fix NULL vs IS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <de6d8985-cd2e-494e-8be0-473612f1b363@kernel.org>
Date: Fri, 7 Mar 2025 12:18:04 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Charles Han <hanchunchao@...pur.com>, mturquette@...libre.com,
 sboyd@...nel.org, duje.mihanovic@...le.hr
Cc: linux-clk@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] clk: mmp: Fix NULL vs IS_ERR() check

On 07/03/2025 07:47, Charles Han wrote:
> The devm_kzalloc() function returns NULL on error, not error pointers.
> Fix the check.
> 
> Fixes: 03437e857b0a ("clk: mmp: Add Marvell PXA1908 APMU driver")
> Signed-off-by: Charles Han <hanchunchao@...pur.com>
> ---
>  drivers/clk/mmp/clk-pxa1908-apmu.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)

This one might be actually correct (in other cases you were blindly
copying some code like returning -ENOMEM while code expects NULL).

Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof