linux-kernel - Re: [PATCH 2/3] mtd: spi-nor: explicitly include <linux/mod

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <924c370e-2c42-4e29-b790-a1d16e7c1e24@linaro.org>
Date: Fri, 7 Mar 2025 12:21:55 +0000
From: Tudor Ambarus <tudor.ambarus@...aro.org>
To: Miquel Raynal <miquel.raynal@...tlin.com>
Cc: Pratyush Yadav <pratyush@...nel.org>, Michael Walle <mwalle@...nel.org>,
 Richard Weinberger <richard@....at>, Vignesh Raghavendra <vigneshr@...com>,
 linux-mtd@...ts.infradead.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/3] mtd: spi-nor: explicitly include
 <linux/mod_devicetable.h>



On 3/7/25 8:22 AM, Miquel Raynal wrote:
> Hello Tudor,

Hi, Miquel!
> 
> On 07/03/2025 at 09:09:06 +02, Tudor Ambarus <tudor.ambarus@...aro.org> wrote:
> 
>> The core driver is using 'struct of_device_id' and relies on implicit
>> inclusion of <linux/mod_devicetable.h>, which comes from
>> <linux/of_platform.h>.
> 
> It is actually included from of.h now (since patch 1) and I wonder
> whether there is a need for it to be included explicitly. As a user it
> feels like "of.h" should already include whatever is needed for us (and

Seems so. I'll drop this patch. Thanks!
ta