linux-kernel - Re: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202503072006.B920348F@keescook>
Date: Fri, 7 Mar 2025 20:07:01 -0800
From: Kees Cook <kees@...nel.org>
To: Pedro Falcato <pedro.falcato@...il.com>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, jack@...e.cz,
	ebiederm@...ssion.com, sunliming@...ux.dev,
	linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org, sunliming@...inos.cn,
	kernel test robot <lkp@...el.com>
Subject: Re: [PATCH V2] fs: binfmt_elf_efpic: fix variable set but not used
 warning

On Sat, Mar 08, 2025 at 04:01:50AM +0000, Pedro Falcato wrote:
> On Sat, Mar 8, 2025 at 3:45 AM Kees Cook <kees@...nel.org> wrote:
> >
> > On Sat, 08 Mar 2025 10:27:54 +0800, sunliming@...ux.dev wrote:
> > > Fix below kernel warning:
> > > fs/binfmt_elf_fdpic.c:1024:52: warning: variable 'excess1' set but not
> > > used [-Wunused-but-set-variable]
> > >
> > >
> >
> > Adjusted Subject for typos.
> >
> > Applied to for-next/execve, thanks!
> >
> > [1/1] binfmt_elf_fdpic: fix variable set but not used warning
> >       https://git.kernel.org/kees/c/7845fe65b33d
> >
> 
> FYI, there's a typo so this patch won't compile
> 
> >+ unsiged long excess1
> >+ = PAGE_SIZE - ((maddr + phdr->p_filesz) & ~PAGE_MASK);
> 
> s/unsiged/unsigned/

D'oh. Fixing in my tree..

-- 
Kees Cook