linux-kernel - RE: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver to support NTMP

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PAXPR04MB851024A8448430F298831ADD88D42@PAXPR04MB8510.eurprd04.prod.outlook.com>
Date: Sat, 8 Mar 2025 06:58:29 +0000
From: Wei Fang <wei.fang@....com>
To: Jakub Kicinski <kuba@...nel.org>
CC: Claudiu Manoil <claudiu.manoil@....com>, Vladimir Oltean
	<vladimir.oltean@....com>, Clark Wang <xiaoning.wang@....com>,
	"andrew+netdev@...n.ch" <andrew+netdev@...n.ch>, "davem@...emloft.net"
	<davem@...emloft.net>, "edumazet@...gle.com" <edumazet@...gle.com>,
	"pabeni@...hat.com" <pabeni@...hat.com>, "christophe.leroy@...roup.eu"
	<christophe.leroy@...roup.eu>, "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>,
	"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>
Subject: RE: [PATCH v3 net-next 01/13] net: enetc: add initial netc-lib driver
 to support NTMP

> On Sat, 8 Mar 2025 02:05:35 +0000 Wei Fang wrote:
> > > > On Tue,  4 Mar 2025 15:21:49 +0800 Wei Fang wrote:
> > > hm..., there are some interfaces of netc-lib are used in common .c
> > > files in downstream, so I used "ifdef" in downstream. Now for the
> > > upstream, I'm going to separate them from the common .c files. So
> > > yes, we can remove it now.
> >
> > Sorry, I misread the header file. The ifdef in ntmp.h is needed
> > because the interfaces in this header file will be used by the
> > enetc-core and enetc-vf drivers. For the ENETC v1 (LS1028A platform),
> > it will not select NXP_NETC_LIB.
> 
> Meaning FSL_ENETC ? And the calls are in FSL_ENETC_CORE ?

Yes, ENETC v1 uses FSL_ENETC, and some of the functions in ntmp.h
are called in FSL_ENETC_CORE, enetc-core is common driver which
provides interfaces to ENETC (v1 and v4) PF and VF drivers.