linux-kernel - Re: [PATCH] fs: support filename refcount without atomics

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202503082153.UnKZ6sGP-lkp@intel.com>
Date: Sat, 8 Mar 2025 21:35:54 +0800
From: kernel test robot <lkp@...el.com>
To: Mateusz Guzik <mjguzik@...il.com>, brauner@...nel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	viro@...iv.linux.org.uk, jack@...e.cz, linux-kernel@...r.kernel.org,
	linux-fsdevel@...r.kernel.org, io-uring@...r.kernel.org,
	audit@...r.kernel.org, axboe@...nel.dk,
	Mateusz Guzik <mjguzik@...il.com>
Subject: Re: [PATCH] fs: support filename refcount without atomics

Hi Mateusz,

kernel test robot noticed the following build errors:

[auto build test ERROR on brauner-vfs/vfs.all]
[also build test ERROR on linus/master v6.14-rc5 next-20250307]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Mateusz-Guzik/fs-support-filename-refcount-without-atomics/20250308-002442
base:   https://git.kernel.org/pub/scm/linux/kernel/git/vfs/vfs.git vfs.all
patch link:    https://lore.kernel.org/r/20250307161155.760949-1-mjguzik%40gmail.com
patch subject: [PATCH] fs: support filename refcount without atomics
config: i386-buildonly-randconfig-003-20250308 (https://download.01.org/0day-ci/archive/20250308/202503082153.UnKZ6sGP-lkp@intel.com/config)
compiler: clang version 19.1.7 (https://github.com/llvm/llvm-project cd708029e0b2869e80abe31ddb175f7c35361f90)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20250308/202503082153.UnKZ6sGP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202503082153.UnKZ6sGP-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/x86/kernel/asm-offsets.c:14:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:17:
>> include/linux/fs.h:2875:19: error: no member named 'owner' in 'struct filename'
    2875 |         VFS_BUG_ON(name->owner != current && !name->is_atomic);
         |                    ~~~~  ^
   include/linux/vfsdebug.h:35:47: note: expanded from macro 'VFS_BUG_ON'
      35 | #define VFS_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond)
         |                                               ^~~~
   include/linux/build_bug.h:30:63: note: expanded from macro 'BUILD_BUG_ON_INVALID'
      30 | #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))
         |                                                               ^
   In file included from arch/x86/kernel/asm-offsets.c:14:
   In file included from include/linux/suspend.h:5:
   In file included from include/linux/swap.h:9:
   In file included from include/linux/memcontrol.h:13:
   In file included from include/linux/cgroup.h:17:
   include/linux/fs.h:2884:19: error: no member named 'owner' in 'struct filename'
    2884 |         VFS_BUG_ON(name->owner != current && !name->is_atomic);
         |                    ~~~~  ^
   include/linux/vfsdebug.h:35:47: note: expanded from macro 'VFS_BUG_ON'
      35 | #define VFS_BUG_ON(cond) BUILD_BUG_ON_INVALID(cond)
         |                                               ^~~~
   include/linux/build_bug.h:30:63: note: expanded from macro 'BUILD_BUG_ON_INVALID'
      30 | #define BUILD_BUG_ON_INVALID(e) ((void)(sizeof((__force long)(e))))
         |                                                               ^
   2 errors generated.
   make[3]: *** [scripts/Makefile.build:102: arch/x86/kernel/asm-offsets.s] Error 1 shuffle=2759713076
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1264: prepare0] Error 2 shuffle=2759713076
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:251: __sub-make] Error 2 shuffle=2759713076
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:251: __sub-make] Error 2 shuffle=2759713076
   make: Target 'prepare' not remade because of errors.


vim +2875 include/linux/fs.h

  2866	
  2867	static inline void makeatomicname(struct filename *name)
  2868	{
  2869		VFS_BUG_ON(IS_ERR_OR_NULL(name));
  2870		/*
  2871		 * The name can legitimately already be atomic if it was cached by audit.
  2872		 * If switching the refcount to atomic, we need not to know we are the
  2873		 * only non-atomic user.
  2874		 */
> 2875		VFS_BUG_ON(name->owner != current && !name->is_atomic);
  2876		/*
  2877		 * Don't bother branching, this is a store to an already dirtied cacheline.
  2878		 */
  2879		name->is_atomic = true;
  2880	}
  2881	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki