linux-kernel - Re: [PATCH net-next v2 2/7] net: usb: lan78xx: Move fixed PHY cleanup to lan78xx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250308145412.1f7944d4@fedora.home>
Date: Sat, 8 Mar 2025 14:54:12 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Oleksij Rempel <o.rempel@...gutronix.de>
Cc: "David S. Miller" <davem@...emloft.net>, Eric Dumazet
 <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
 <pabeni@...hat.com>, Woojung Huh <woojung.huh@...rochip.com>, Andrew Lunn
 <andrew+netdev@...n.ch>, Russell King <rmk+kernel@...linux.org.uk>,
 Thangaraj Samynathan <Thangaraj.S@...rochip.com>, Rengarajan Sundararajan
 <Rengarajan.S@...rochip.com>, kernel@...gutronix.de,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
 UNGLinuxDriver@...rochip.com, Phil Elwell <phil@...pberrypi.org>
Subject: Re: [PATCH net-next v2 2/7] net: usb: lan78xx: Move fixed PHY
 cleanup to lan78xx_unbind()

Hi Oleksij,

On Fri,  7 Mar 2025 19:24:27 +0100
Oleksij Rempel <o.rempel@...gutronix.de> wrote:

> Move the cleanup of the fixed PHY to the lan78xx_unbind() function,
> which is invoked during both the probe and disconnect paths.  This
> change eliminates duplicate cleanup code in the disconnect routine and
> ensures that the fixed PHY is properly freed during other probe steps.
> 
> Signed-off-by: Oleksij Rempel <o.rempel@...gutronix.de>
> ---

The commit message looks totally unrelated to the content of the patch
:(

Maxime

>  drivers/net/usb/lan78xx.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/usb/lan78xx.c b/drivers/net/usb/lan78xx.c
> index 01967138bc8c..4efe7a956667 100644
> --- a/drivers/net/usb/lan78xx.c
> +++ b/drivers/net/usb/lan78xx.c
> @@ -2688,8 +2688,8 @@ static int lan78xx_phy_init(struct lan78xx_net *dev)
>  
>  	ret = phylink_connect_phy(dev->phylink, phydev);
>  	if (ret) {
> -		netdev_err(dev->net, "can't attach PHY to %s\n",
> -			   dev->mdiobus->id);
> +		netdev_err(dev->net, "can't attach PHY to %s, error %pe\n",
> +			   dev->mdiobus->id, ERR_PTR(ret));
>  		return -EIO;
>  	}
>