linux-kernel - Re: [PATCH 3/7] usb: common: usb-conn-gpio: switch psy_cfg from of

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <eqfqv2tkfretqzvt74o5dvj5yixkfc3h3my4bhskvhtsrbmtwp@poryvs4oipnp>
Date: Sat, 8 Mar 2025 17:33:05 +0100
From: Sebastian Reichel <sebastian.reichel@...labora.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Mark Brown <broonie@...nel.org>, Linus Walleij <linus.walleij@...aro.org>, 
	Hans de Goede <hdegoede@...hat.com>, Liam Girdwood <lgirdwood@...il.com>, 
	Chen-Yu Tsai <wens@...e.org>, Matti Vaittinen <mazziesaccount@...il.com>, 
	Pali Rohár <pali@...nel.org>, Paul Cercueil <paul@...pouillou.net>, 
	Samuel Holland <samuel@...lland.org>, David Lechner <david@...hnology.com>, 
	Krzysztof Kozlowski <krzk@...nel.org>, Marek Szyprowski <m.szyprowski@...sung.com>, 
	Sebastian Krzyszkowiak <sebastian.krzyszkowiak@...i.sm>, Purism Kernel Team <kernel@...i.sm>, 
	Bartosz Golaszewski <brgl@...ev.pl>, Konrad Dybcio <konradybcio@...nel.org>, 
	Matthias Brugger <matthias.bgg@...il.com>, 
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Orson Zhai <orsonzhai@...il.com>, 
	Baolin Wang <baolin.wang@...ux.alibaba.com>, Chunyan Zhang <zhang.lyra@...il.com>, linux-pm@...r.kernel.org, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH 3/7] usb: common: usb-conn-gpio: switch psy_cfg from
 of_node to fwnode

Hi,

On Sat, Mar 08, 2025 at 10:34:45AM +0100, Konrad Dybcio wrote:
> On 8.03.2025 6:57 AM, Greg Kroah-Hartman wrote:
> > On Sat, Mar 08, 2025 at 02:10:29AM +0100, Sebastian Reichel wrote:
> >> On Tue, Feb 25, 2025 at 04:32:50AM +0100, Greg Kroah-Hartman wrote:
> >>> On Tue, Feb 25, 2025 at 12:21:36AM +0100, Sebastian Reichel wrote:
> >>>> In order to remove .of_node from the power_supply_config struct,
> >>>> use .fwnode instead.
> >>>>
> >>>> Signed-off-by: Sebastian Reichel <sebastian.reichel@...labora.com>
> >>>> ---
> >>>>  drivers/usb/common/usb-conn-gpio.c | 2 +-
> >>>>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>>>
> >>>> diff --git a/drivers/usb/common/usb-conn-gpio.c b/drivers/usb/common/usb-conn-gpio.c
> >>>> index aa710b50791b0282be0a6a26cffdd981b794acaa..1e36be2a28fd5ca5e1495b7923e4d3e25d7cedef 100644
> >>>> --- a/drivers/usb/common/usb-conn-gpio.c
> >>>> +++ b/drivers/usb/common/usb-conn-gpio.c
> >>>> @@ -158,7 +158,7 @@ static int usb_conn_psy_register(struct usb_conn_info *info)
> >>>>  	struct device *dev = info->dev;
> >>>>  	struct power_supply_desc *desc = &info->desc;
> >>>>  	struct power_supply_config cfg = {
> >>>> -		.of_node = dev->of_node,
> >>>> +		.fwnode = dev_fwnode(dev),
> >>>>  	};
> >>>>  
> >>>>  	desc->name = "usb-charger";
> >>>>
> >>>> -- 
> >>>> 2.47.2
> >>>
> >>> Acked-by: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
> >>
> >> Please just merge this patch through the USB tree.
> >>
> >> There are no dependencies and I will send a new version for the
> >> later patches, but they won't make it to 6.15 as I want enough
> >> time in linux-next for them. This patch is rather simple and
> >> getting it merged now means we avoid immutable branches or
> >> merging through the wrong tree in the 6.16 cycle.
> > 
> > Attempting to merge a single patch out of a series is hard with our
> > current tools, you know that.

Sorry, I did not know your tooling has issues with that. AFAIK most
maintainers are using b4 nowadays, which makes it really easy. Might
be I am biased because I mostly work on ARM stuff where series often
have patches for the driver and the device tree and thus merging
partial patch series is basically the norm.

> > Please resend just the single patch if you want that applied.
> 
> b4 shazam <msgid> -P 3
> 
> to apply the third patch (such as this one) in a thread
> unless you use some other set of tools..

Exactly.

But I can send this patch separately of course.

Greetings,

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)