linux-kernel - Re: [PATCH] rust: task: fix `SAFETY` comment for Task::wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m27c4zfolu.fsf@posteo.net>
Date: Sat, 08 Mar 2025 16:56:13 +0000
From: Charalampos Mitrodimas <charmitro@...teo.net>
To: Panagiotis Foliadis <pfoliadis@...teo.net>
Cc: Miguel Ojeda <ojeda@...nel.org>,  Alex Gaynor <alex.gaynor@...il.com>,
  Boqun Feng <boqun.feng@...il.com>,  Gary Guo <gary@...yguo.net>,
  Björn
 Roy Baron <bjorn3_gh@...tonmail.com>,  Benno Lossin
 <benno.lossin@...ton.me>,  Andreas Hindborg <a.hindborg@...nel.org>,
  Alice Ryhl <aliceryhl@...gle.com>,  Trevor Gross <tmgross@...ch.edu>,
  Christian Brauner <brauner@...nel.org>,  rust-for-linux@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH] rust: task: fix `SAFETY` comment for Task::wake_up

Panagiotis Foliadis <pfoliadis@...teo.net> writes:

> The `SAFETY` comment inside the `wake_up` function references
> erroneously the `signal_pending` function instead of the
> `wake_up_process` which is actually called. Fix the comment
> to reference the correct function.
>
> Fixes: fe95f58320e6 ("rust: task: adjust safety comments in Task methods")
> Signed-off-by: Panagiotis Foliadis <pfoliadis@...teo.net>
> ---
>  rust/kernel/task.rs | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

You can add,
Reviewed-by: Charalampos Mitrodimas <charmitro@...teo.net>

--
C. Mitrodimas