[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <f3e36573-e370-4f70-94d8-7a240d366e60@gmx.de>
Date: Sat, 8 Mar 2025 22:26:16 +0100
From: Helge Deller <deller@....de>
To: Uwe Kleine-König <u.kleine-koenig@...libre.com>,
Markus Elfring <Markus.Elfring@....de>
Cc: kernel-janitors@...r.kernel.org, linux-fbdev@...r.kernel.org,
dri-devel@...ts.freedesktop.org, Antonino Daplas <adaplas@....net>,
Thomas Zimmermann <tzimmermann@...e.de>, Yihao Han <hanyihao@...o.com>,
cocci@...ia.fr, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH RESEND] video: au1100fb: Move a variable assignment behind
a null pointer check in au1100fb_setmode()
On 3/3/25 10:19, Uwe Kleine-König wrote:
> Hello,
>
> On Sun, Mar 02, 2025 at 07:02:12PM +0100, Markus Elfring wrote:
>> From: Markus Elfring <elfring@...rs.sourceforge.net>
>> Date: Thu, 13 Apr 2023 21:35:36 +0200
>>
>> The address of a data structure member was determined before
>> a corresponding null pointer check in the implementation of
>> the function “au1100fb_setmode”.
>>
>> Thus avoid the risk for undefined behaviour by moving the assignment
>> for the variable “info” behind the null pointer check.
>>
>> This issue was detected by using the Coccinelle software.
>>
>> Fixes: 3b495f2bb749 ("Au1100 FB driver uplift for 2.6.")
>> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
>
> Acked-by: Uwe Kleine-König <u.kleine-koenig@...libre.com>
applied to fbdev git tree (with minor modifications to commit
message and without stable tags).
Helge
Powered by blists - more mailing lists