linux-kernel - Re: [PATCH] clocksource: timer-sp804: Fix read_current_timer() issue when clock source is not registered

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <BYAPR12MB3205811E28AD92FD6610F886D5D42@BYAPR12MB3205.namprd12.prod.outlook.com>
Date: Sat, 8 Mar 2025 02:32:53 +0000
From: stephen eta zhou <stephen.eta.zhou@...look.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, Daniel Lezcano
	<daniel.lezcano@...aro.org>
CC: "tglx@...utronix.de" <tglx@...utronix.de>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource: timer-sp804: Fix read_current_timer() issue
 when clock source is not registered

> In case you actually consider applying this - some of the patches or
> their descriptions were generated by sort of AI tools, thus approach
> with caution.

> It was already pointed out that patches might be a garbage output of AI.
> Also they were not tested, even though what is claimed here "debugging
> on ...".

Hi  Krzysztof

I want to point out that this code was debugged by me personally, and I can provide a complete debugging record. 
I want to point out that the reason why my answers to some of the previous patches are a bit AI-like is because I am a bit reserved about submitting code to the kernel community, and I am worried that some answers may not be friendly, so I used AI to polish some of my answers.

But I must point out that this is the result of my own debugging and the solution I came up with after careful consideration.

Thanks
Stephen

________________________________________
From: Krzysztof Kozlowski <krzk@...nel.org>
Sent: Friday, March 7, 2025 19:17
To: Daniel Lezcano <daniel.lezcano@...aro.org>; stephen eta zhou <stephen.eta.zhou@...look.com>
Cc: tglx@...utronix.de <tglx@...utronix.de>; linux-kernel@...r.kernel.org <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] clocksource: timer-sp804: Fix read_current_timer() issue when clock source is not registered
 
On 07/03/2025 09:10, Daniel Lezcano wrote:
>
> Hi Stephen,
>
> thanks for the proposed fix
>
> On 21/02/2025 04:46, stephen eta zhou wrote:
>> Hi daniel
>>
>> While debugging on the vexpress-v2p-ca9 platform, I discovered that the read_current_timer API wasn't functioning correctly. The issue was that the SP804 driver lacked ARM32 support and did not register read_current_timer. To add ARM32 compatibility, I’ve submitted this patch. Without it, using SP804 as the timer on ARM32 causes issues with boot_init_stack_canary when inserting the canary value into the interrupt stack, and also affects entropy generation and collection, resulting in incorrect rdseed values.
>
> It is better to put that information in the changelog and provide a
> fixed format of the patch description.
Daniel,

In case you actually consider applying this - some of the patches or
their descriptions were generated by sort of AI tools, thus approach
with caution.

It was already pointed out that patches might be a garbage output of AI.
Also they were not tested, even though what is claimed here "debugging
on ...".

Best regards,
Krzysztof