linux-kernel - Re: [PATCH] fbdev: lcdcfb: Register sysfs groups through driver core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <e88f483c-1439-40f2-8945-dfa4de373153@gmx.de>
Date: Sun, 9 Mar 2025 03:00:35 +0100
From: Helge Deller <deller@....de>
To: oushixiong1025@....com
Cc: Thomas Zimmermann <tzimmermann@...e.de>,
 Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>,
 Lee Jones <lee@...nel.org>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, Arnd Bergmann <arnd@...db.de>,
 linux-fbdev@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-kernel@...r.kernel.org, Shixiong Ou <oushixiong@...inos.cn>
Subject: Re: [PATCH] fbdev: lcdcfb: Register sysfs groups through driver core

On 2/19/25 09:44, oushixiong1025@....com wrote:
> From: Shixiong Ou <oushixiong@...inos.cn>
>
> [WHY]
>     1. The driver forgot to call device_remove_file()
>     in sh_mobile_lcdc_overlay_fb_unregister(), and there was
>     no error handling when calling device_create_file() failed.
>
>     2. This should probably use device_add_group() instead of
>     individual files to simplify both creation and removal. [Arnd]
>
>     3. The driver core can register and cleanup sysfs groups already.
>     as commit 95cdd538e0e5 ("fbdev: efifb: Register sysfs groups
>     through driver core").
>
> [HOW]
>     Register sysfs groups through driver core.
>
> Signed-off-by: Shixiong Ou <oushixiong@...inos.cn>
> ---
>   drivers/video/fbdev/sh_mobile_lcdcfb.c | 29 ++++++++++++--------------
>   1 file changed, 13 insertions(+), 16 deletions(-)

applied.

Thanks!
Helge