linux-kernel - Re: [PATCH v4 00/12] platform/x86: alienware-wmi-wmax: HWMON support + DebugFS + Improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D8BV3JTOCPI1.3OY62UIJOLJQL@gmail.com>
Date: Sun, 09 Mar 2025 11:05:09 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: "Guenter Roeck" <linux@...ck-us.net>, Ilpo Järvinen
 <ilpo.jarvinen@...ux.intel.com>, "Armin Wolf" <W_Armin@....de>
Cc: "Hans de Goede" <hdegoede@...hat.com>,
 <platform-driver-x86@...r.kernel.org>, <Dell.Client.Kernel@...l.com>,
 <linux-kernel@...r.kernel.org>, "Jean Delvare" <jdelvare@...e.com>,
 <linux-hwmon@...r.kernel.org>, "Bagas Sanjaya" <bagasdotme@...il.com>
Subject: Re: [PATCH v4 00/12] platform/x86: alienware-wmi-wmax: HWMON
 support + DebugFS + Improvements

Hi Guenter,

On Sat Mar 8, 2025 at 4:23 PM -05, Guenter Roeck wrote:
> On 3/8/25 12:23, Kurt Borja wrote:
>> Hi all,
>> 
>> This set mainly adds hwmon and manual fan control support (patches 7-8)
>> to the alienware-wmi driver, after some improvements.
>> 
>> I have a question for anyone that may know how to solve it. In version 2
>> of these series the kernel test robot found a build error
>> 
>> 	https://lore.kernel.org/platform-driver-x86/202503051819.bQ9P70Og-lkp@intel.com/
>> 
>> I think this happened because
>> 
>> 	CONFIG_ALIENWARE_WMI=y
>> 
>> while
>> 
>> 	CONFIG_ACPI_PLATFORM_PROFILE=m
>> 	CONFIG_HWMON=m
>> 
>> How should I Kconfig to avoid this?
>> 
>
> If hwmon is considered to be mandatory, you'll need
> 	depends on HWMON=y
>
> Alternative would be to use
> 	depends on HWMON=y || HWMON=n
>
> and use IS_ENABLED(). Something like
>
> 	if (IS_ENABLED(CONFIG_HWMON) && awcc->hwmon) {
> 		ret = awcc_hwmon_init(wdev);
> 		if (ret)
> 			return ret;
> 	}
>
> Using IS_REACHABLE() would be another option.

Oh - Now I understand why I saw this pattern in a few drivers. I'll
think about this option for the next revision.

>
> The CONFIG_ACPI_PLATFORM_PROFILE problem is probably similar. You can not
> have CONFIG_ALIENWARE_WMI as boolean depending on code which can be built
> as module.

Actually ALIENWARE_WMI is tristate, but the symbol that actually pulls
the dependency is ALIENWARE_WMI_WMAX, which is indeed bool.

Thank you, this gave me the clue to fix the issue!

-- 
 ~ Kurt

>
> Guenter