linux-kernel - Re: [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <sf7hqjyzal2jmbrf72xxj4cewrkq6bsjwlkbinqv2zan57cq3s@hwhfwmabtk5q>
Date: Sun, 9 Mar 2025 20:43:55 +0100
From: Jorge Marques <gastmaier@...il.com>
To: Conor Dooley <conor@...nel.org>
Cc: Jorge Marques <jorge.marques@...log.com>, 
	Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>, 
	Michael Hennerich <Michael.Hennerich@...log.com>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, 
	Jonathan Corbet <corbet@....net>, David Lechner <dlechner@...libre.com>, linux-iio@...r.kernel.org, 
	linux-kernel@...r.kernel.org, devicetree@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 2/4] dt-bindings: iio: adc: Add adi,ad4052

> > +  compatible:
> > +    enum:
> > +      - adi,ad4050
> > +      - adi,ad4052
> > +      - adi,ad4056
> > +      - adi,ad4058
> 
> Can you mention in your commit message what differs between these
> devices that makes picking one as the "base"/fallback compatible
> unsuitable please?
Sure, to be added:

 Each variant of the family differs in speed and resolution, resulting
 in different scan types and spi word sizes, that are matched by the
 compatible with the chip_info.
 The device contains two required interrupts (gp0, gp1) and one optional
 gpio (cnv).

> > +
> > +  vdd-supply: true
> > +  vdd_1_8-supply: true
> 
> You're allowed to use . in property names, and the _s should be -s.
> That said, vdd and vdd 1.8? Shouldn't both have the voltage in them in
> that case?
I overlooked the supplies, the correct are vdd, vio as mandatory,
and vref is optional.

Jorge