linux-kernel - Re: [PATCH v3] ARM: dts: nexus4: Initial dts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c67defb5-f677-45e0-9316-cf0a60238393@ixit.cz>
Date: Sun, 9 Mar 2025 22:39:08 +0100
From: David Heidelberg <david@...t.cz>
To: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>
Cc: Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley
 <conor+dt@...nel.org>, Kees Cook <kees@...nel.org>,
 Tony Luck <tony.luck@...el.com>, "Guilherme G. Piccoli"
 <gpiccoli@...lia.com>, linux-arm-msm@...r.kernel.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-hardening@...r.kernel.org, Ivan Belokobylskiy <belokobylskij@...il.com>
Subject: Re: [PATCH v3] ARM: dts: nexus4: Initial dts

On 09/03/2025 10:36, Dmitry Baryshkov wrote:
> On Sun, Mar 09, 2025 at 10:17:29AM +0100, David Heidelberg wrote:
>> Hello Dmitry!
>>
>> Thank you for looking into it. See replies.
>>
>> On 09/03/2025 09:33, Dmitry Baryshkov wrote:
>>> On Sun, Mar 09, 2025 at 01:45:51AM +0100, David Heidelberg via B4 Relay wrote:
>>>> +
>>>> +&riva {
>>>> +	status = "okay";
>>>> +	pinctrl-names = "default";
>>>> +	pinctrl-0 = <&riva_wlan_pin_a>;
>>>
>>> Where is it defined? Also pinctrl-names should come after pinctrl-N.
>>
>> definition is kinda aside in qcom-apq8064-pins.dtsi .
> 
> Ack, missed it.
> 
>>
>> All other suggestions incorporated, if it's OK otherwise, let me send v2
> 
> I think this also needs several supplies in the riva device itself and
> in the iris subdevice. See qcom-apq8064-sony-xperia-lagan-yuga.dts.
> 

I don't have the device in my hands, so if I figure out the regulators, 
I'll not be able to test new WiFi setup. I would drop the WiFi node for 
now, so at least the base regulators and eMMC gets and possible someone 
with devices in his hand can push more functionality forward, if you 
don't object.

There is slowly forming some APQ8064/MSM8960 community, so I think there 
will be updates, now I would just settle with minimum, so our downstream 
changes will contain only small chunks to get upstreamed.

Would you be ok with this approach?

>>
>> Thank you
>> David
>>
>>>
>>>> +};
>>>>
>>>> ---
>>>> base-commit: 0a2f889128969dab41861b6e40111aa03dc57014
>>>> change-id: 20250309-lg-nexus4-mako-da0833885b26
>>>>
>>>> Best regards,
>>>> -- 
>>>> David Heidelberg <david@...t.cz>
>>>>
>>>>
>>>
>>
>> -- 
>> David Heidelberg
>>
> 

-- 
David Heidelberg