linux-kernel - Re: [PATCH v2 2/3] arm64: dts: qcom: x1e78100-t14s: Add LCD variant with backlight support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfd2c51a-cf2a-45f1-a926-65388d2c3ed6@kernel.org>
Date: Mon, 10 Mar 2025 15:35:08 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Abel Vesa <abel.vesa@...aro.org>, Bjorn Andersson <andersson@...nel.org>,
 Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>
Cc: Johan Hovold <johan@...nel.org>,
 Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
 linux-kernel@...r.kernel.org, Sebastian Reichel <sre@...nel.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: qcom: x1e78100-t14s: Add LCD variant
 with backlight support

On 10/03/2025 15:15, Abel Vesa wrote:
> Due to the fact that Lenovo Thinkpad T14s Gen6 is available with both
> OLED and LCD, the backlight control differs HW-wise. For the LCD variant,
> the panel's backlight is controlled via one of the PWMs provided by the
> PMK8550 PMIC. For the OLED variant, the backlight is internal to the
> panel and therefore it is not described in devicetree.
> 
> For this reason, create a generic dtsi for the T14s by renaming the
> existing dts. While at it, add a node name to panel and drop the enable
> gpio and pinctrl properties from the panel node. Then add the LCD variant
> dts file with the old name and describe all backlight related nodes.
> 
> So the existing dts will now be used for LCD variant while for OLED new
> dts will be added.
> 
> Tested-by: Sebastian Reichel <sre@...nel.org>
> Signed-off-by: Abel Vesa <abel.vesa@...aro.org>


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof