linux-kernel - Re: [PATCH] platform/x86: dell: Fix ALIENWARE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <D8COAMZV0RBJ.1C66Q3AVETTD8@gmail.com>
Date: Mon, 10 Mar 2025 09:57:57 -0500
From: "Kurt Borja" <kuurtb@...il.com>
To: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
Cc: "Hans de Goede" <hdegoede@...hat.com>,
 <platform-driver-x86@...r.kernel.org>, "LKML"
 <linux-kernel@...r.kernel.org>, "kernel test robot" <lkp@...el.com>
Subject: Re: [PATCH] platform/x86: dell: Fix ALIENWARE_WMI dependencies

Hi Ilpo,

On Mon Mar 10, 2025 at 9:29 AM -05, Ilpo Järvinen wrote:
> On Sun, 9 Mar 2025, Kurt Borja wrote:
>
>> If ACPI_PLATFORM_PROFILE is selected by ALIENWARE_WMI_WMAX, the former
>> is forced to be at least =m, because the latter is a bool.
>> 
>> This allows the following config:
>> 
>> 	CONFIG_ALIENWARE_WMI=y
>> 	CONFIG_ACPI_PLATFORM_PROFILE=m
>
> Hi,
>
> selecting from =y should not result in =m for the other symbol. This is 
> a bug in Kconfig infrastructure.
>
> I ran across this a few years back and even had a test case to prove the 
> select bug but back then the original problem eventually was solved in a 
> different way which no longer hit the problem. I never could figure out
> how to fix the kconfig logic though without breaking something and it 
> ended up into low priority bin and never got solved.
>
> Sadly, it seems I've lost the test case patch that exhibits the bug 
> somewhere... I'll try to look for it from my archived files.

That's funny.

I thought this was a Kconfig quirk, that resulted from the following
hierarchy:

Type		0	1	2
=============== ======= ======= =======
Bool		n	y
Tristate	n	m	y

So a <bool> selecting the <tristate> would force it to be at least =m.

The same thing happens with depend, where a dependecy would be fulfilled
for a <bool> if a <tristate> was at least =m. That's why in the kernel
robot report the linking error was also due to the HWMON dependency.

Anyway, this patch could serve as a workaround if you feel it's
necessary. I'm going to put the HWMON dependecy in the ALIENWARE_WMI
symbol for my other series.

-- 
 ~ Kurt