linux-kernel - [PATCH] tpm: Clarify "auth session active" message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250310153942.15038-1-kernel.org@pileofstuff.org>
Date: Mon, 10 Mar 2025 15:39:41 +0000
From: Andrew Sayers <kernel.org@...eofstuff.org>
To: Peter Huewe <peterhuewe@....de>,
	Jarkko Sakkinen <jarkko@...nel.org>,
	Jason Gunthorpe <jgg@...pe.ca>
Cc: Andrew Sayers <kernel.org@...eofstuff.org>,
	linux-integrity@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] tpm: Clarify "auth session active" message

Without context, the obvious reading of "auth session is active" is
"auth session successfully activated".  In fact, this message means
"redundant extra attempt to activate auth session".

Signed-off-by: Andrew Sayers <kernel.org@...eofstuff.org>
---
 drivers/char/tpm/tpm2-sessions.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/char/tpm/tpm2-sessions.c b/drivers/char/tpm/tpm2-sessions.c
index 3f89635ba5e8..21589a75ed04 100644
--- a/drivers/char/tpm/tpm2-sessions.c
+++ b/drivers/char/tpm/tpm2-sessions.c
@@ -982,7 +982,7 @@ int tpm2_start_auth_session(struct tpm_chip *chip)
 	int rc;
 
 	if (chip->auth) {
-		dev_dbg_once(&chip->dev, "auth session is active\n");
+		dev_dbg_once(&chip->dev, "auth session already active\n");
 		return 0;
 	}
 
-- 
2.47.2