linux-kernel - Re: [PATCH 4/4] ARM: dts: stm32: add initial support for stm32mp157-ultra-fly-sbc board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6af3a9fe-0c0b-497d-b143-77edc12f0c1e@kernel.org>
Date: Mon, 10 Mar 2025 17:08:24 +0100
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Goran Rađenović <goran.radni@...il.com>,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 Goran Rađenović <gradenovic@...ratronik.de>,
 Börge Strümpfel <bstruempfel@...ratronik.de>,
 Maxime Coquelin <mcoquelin.stm32@...il.com>,
 Alexandre Torgue <alexandre.torgue@...s.st.com>
Cc: devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-stm32@...md-mailman.stormreply.com,
 linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH 4/4] ARM: dts: stm32: add initial support for
 stm32mp157-ultra-fly-sbc board

On 10/03/2025 16:48, Goran Rađenović wrote:
> +&gpioj {
> +	gpio-line-names =
> +	"", "", "", "", "", "", "", "",
> +	"", "", "", "", "", "", "", "";
> +};
> +
> +&gpiok {
> +	gpio-line-names =
> +	"", "", "", "", "", "", "", "",
> +	"", "", "", "", "", "", "", "";
> +};
> +
> +&gpioz {
> +	gpio-line-names =
> +	"", "", "", "#SPI_CS2", "", "", "", "",
> +	"", "", "", "", "", "", "", "";
> +};
> +
> +&gpu {
> +	status = "okay";
> +};
> +
> +&i2c1 {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&i2c1_ux_pins_a>;
> +	pinctrl-1 = <&i2c1_ux_pins_sleep_a>;
> +	i2c-scl-rising-time-ns = <100>;
> +	i2c-scl-falling-time-ns = <7>;
> +	status = "okay";
> +	/delete-property/dmas;
> +	/delete-property/dma-names;
> +
> +	rtc@32 {
> +		compatible = "epson,rx8900";
> +		reg = <0x32>;
> +		epson,vdet-disable;
> +		trickle-diode-disable;
> +	};
> +};
> +
> +&i2c4 {
> +	pinctrl-names = "default", "sleep";
> +	pinctrl-0 = <&i2c4_ux_pins_a>;
> +	pinctrl-1 = <&i2c4_ux_pins_sleep_a>;
> +	i2c-scl-rising-time-ns = <185>;
> +	i2c-scl-falling-time-ns = <20>;
> +	status = "okay";
> +	/delete-property/dmas;
> +	/delete-property/dma-names;
> +
> +	pmic: stpmic@33 {

Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation

pmic?

> +		compatible = "st,stpmic1";
> +		reg = <0x33>;
> +		interrupts-extended = <&exti 0 IRQ_TYPE_EDGE_FALLING>;
> +		interrupt-controller;
> +		#interrupt-cells = <2>;
> +		status = "okay";

Does not look disabled


...


> +	dac_ux_ch2_pins_a: dac_ux-ch2-0 {

No underscores in node names.

> +		pins {
> +			pinmux = <STM32_PINMUX('A', 5, ANALOG)>;
> +		};
> +	};
> +




Best regards,
Krzysztof