linux-kernel - Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating only NULL elements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <625983f8-7e52-4f6c-97bb-629596341181@linux.alibaba.com>
Date: Mon, 10 Mar 2025 08:32:42 +0800
From: Gao Xiang <hsiangkao@...ux.alibaba.com>
To: Yunsheng Lin <yunshenglin0825@...il.com>,
 Dave Chinner <david@...morbit.com>, Yunsheng Lin <linyunsheng@...wei.com>
Cc: Yishai Hadas <yishaih@...dia.com>, Jason Gunthorpe <jgg@...pe.ca>,
 Shameer Kolothum <shameerali.kolothum.thodi@...wei.com>,
 Kevin Tian <kevin.tian@...el.com>,
 Alex Williamson <alex.williamson@...hat.com>, Chris Mason <clm@...com>,
 Josef Bacik <josef@...icpanda.com>, David Sterba <dsterba@...e.com>,
 Gao Xiang <xiang@...nel.org>, Chao Yu <chao@...nel.org>,
 Yue Hu <zbestahu@...il.com>, Jeffle Xu <jefflexu@...ux.alibaba.com>,
 Sandeep Dhavale <dhavale@...gle.com>, Carlos Maiolino <cem@...nel.org>,
 "Darrick J. Wong" <djwong@...nel.org>,
 Andrew Morton <akpm@...ux-foundation.org>,
 Jesper Dangaard Brouer <hawk@...nel.org>,
 Ilias Apalodimas <ilias.apalodimas@...aro.org>,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Simon Horman <horms@...nel.org>, Trond Myklebust <trondmy@...nel.org>,
 Anna Schumaker <anna@...nel.org>, Chuck Lever <chuck.lever@...cle.com>,
 Jeff Layton <jlayton@...nel.org>, Neil Brown <neilb@...e.de>,
 Olga Kornievskaia <okorniev@...hat.com>, Dai Ngo <Dai.Ngo@...cle.com>,
 Tom Talpey <tom@...pey.com>, Luiz Capitulino <luizcap@...hat.com>,
 Mel Gorman <mgorman@...hsingularity.net>, kvm@...r.kernel.org,
 virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org,
 linux-btrfs@...r.kernel.org, linux-erofs@...ts.ozlabs.org,
 linux-xfs@...r.kernel.org, linux-mm@...ck.org, netdev@...r.kernel.org,
 linux-nfs@...r.kernel.org
Subject: Re: [PATCH v2] mm: alloc_pages_bulk: remove assumption of populating
 only NULL elements

On 2025/3/9 21:40, Yunsheng Lin wrote:
> On 3/8/2025 2:43 PM, Dave Chinner wrote:
> 
> ...
> 
>>> I tested XFS using the below cmd and testcase, testing seems
>>> to be working fine, or am I missing something obvious here
>>> as I am not realy familiar with fs subsystem yet:
>>
>> That's hardly what I'd call a test. It barely touches the filesystem
>> at all, and it is not exercising memory allocation failure paths at
>> all.
>>
>> Go look up fstests and use that to test the filesystem changes you
>> are making. You can use that to test btrfs and NFS, too.
> 
> Thanks for the suggestion.
> I used the below xfstests to do the testing in a VM, the smoke testing
> seems fine for now, will do a full testing too:
> https://github.com/tytso/xfstests-bld
> 
> Also, it seems the fstests doesn't support erofs yet?

erofs is an read-only filesystem, and almost all xfstests
cases is unsuitable for erofs since erofs needs to preset
dataset in advance for runtime testing and only
read-related interfaces are cared:

You could check erofs-specfic test cases here:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/log/?h=experimental-tests

Also the stress test:
https://git.kernel.org/pub/scm/linux/kernel/git/xiang/erofs-utils.git/commit/?id=6fa861e282408f8df9ab1654b77b563444b17ea1

BTW, I don't like your new interface either, I don't know
why you must insist on this work now that others are
already nak this.  Why do you insist on it so much?

Thanks,
Gao Xiang

> 
>>
>> -Dave.
>>