linux-kernel - Re: [PATCH] cpufreq: tegra186: Share policy per cluster

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250310051127.zsnxoudfsw2ebeil@vireshk-i7>
Date: Mon, 10 Mar 2025 10:41:27 +0530
From: Viresh Kumar <viresh.kumar@...aro.org>
To: Aaron Kling <webgeek1234@...il.com>
Cc: Aaron Kling <luceoscutum@...il.com>,
	"Rafael J. Wysocki" <rafael@...nel.org>,
	Thierry Reding <thierry.reding@...il.com>,
	Jonathan Hunter <jonathanh@...dia.com>, linux-pm@...r.kernel.org,
	linux-tegra@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] cpufreq: tegra186: Share policy per cluster

On 10-03-25, 00:08, Aaron Kling wrote:
> On Sun, Mar 9, 2025 at 11:45 PM Viresh Kumar <viresh.kumar@...aro.org> wrote:
> >
> > On 16-02-25, 10:08, Aaron Kling wrote:
> > > This functionally brings tegra186 in line with tegra210 and tegra194,
> > > sharing a cpufreq policy between all cores in a cluster.
> > >
> > > Signed-off-by: Aaron Kling <webgeek1234@...il.com>
> > > ---
> > >  drivers/cpufreq/tegra186-cpufreq.c | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > >
> > > diff --git a/drivers/cpufreq/tegra186-cpufreq.c b/drivers/cpufreq/tegra186-cpufreq.c
> > > index c7761eb99f3cc..c832a1270e688 100644
> > > --- a/drivers/cpufreq/tegra186-cpufreq.c
> > > +++ b/drivers/cpufreq/tegra186-cpufreq.c
> > > @@ -73,11 +73,18 @@ static int tegra186_cpufreq_init(struct cpufreq_policy *policy)
> > >  {
> > >       struct tegra186_cpufreq_data *data = cpufreq_get_driver_data();
> > >       unsigned int cluster = data->cpus[policy->cpu].bpmp_cluster_id;
> > > +     u32 cpu;
> > >
> > >       policy->freq_table = data->clusters[cluster].table;
> > >       policy->cpuinfo.transition_latency = 300 * 1000;
> > >       policy->driver_data = NULL;
> > >
> > > +     /* set same policy for all cpus in a cluster */
> > > +     for (cpu = 0; cpu < (sizeof(tegra186_cpus)/sizeof(struct tegra186_cpufreq_cpu)); cpu++) {
> >
> > Can't you use ARRAY_SIZE here ?
> 
> I could, just wasn't aware of that macro. Is that enough to send a v2 over?

Yes, please send that and include the tags you received.

-- 
viresh