linux-kernel - Re: [PATCH] mm/damon/sysfs-schemes: avoid Wformat-security warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20250310165320.652617-1-sj@kernel.org>
Date: Mon, 10 Mar 2025 09:53:20 -0700
From: SeongJae Park <sj@...nel.org>
To: SeongJae Park <sj@...nel.org>
Cc: Arnd Bergmann <arnd@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Arnd Bergmann <arnd@...db.de>,
	Hyeongtak Ji <hyeongtak.ji@...com>,
	Honggyu Kim <honggyu.kim@...com>,
	Usama Arif <usamaarif642@...il.com>,
	damon@...ts.linux.dev,
	linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] mm/damon/sysfs-schemes: avoid Wformat-security warning

On Mon, 10 Mar 2025 09:17:58 -0700 SeongJae Park <sj@...nel.org> wrote:

> On Mon, 10 Mar 2025 14:51:37 +0100 Arnd Bergmann <arnd@...nel.org> wrote:
> 
> > From: Arnd Bergmann <arnd@...db.de>
> > 
> > This warning is for potentially user-defined format strings:
> > 
> > mm/damon/sysfs-schemes.c:1664:4: error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
> >  1664 |                         name);
> > 
> > Change this to use "%s" as the format and the name as the argument.
> 
> Thank you for this patch!

I also found there is another similar issue and sent another patch[1] for that.
Thank you again for sharing the issue.

[1] https://lore.kernel.org/20250310165009.652491-1-sj@kernel.org


Thanks,
SJ

[...]